Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create namespace when adding new SSH keys to Virtual Machines (backport #995) #1002

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 24, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related issue: harvester/harvester#5425

Occurred changes and/or fixed issues

Technical notes summary

It adds namespace creation in VirtualMachineSSHKey component, for both pages:

  • Create Virtual Machines
  • Create Virtual Machines templates

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video


This is an automatic backport of pull request #995 done by [Mergify](https://mergify.com).

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 4058f8b)
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
(cherry picked from commit 7112eed)
@torchiaf torchiaf merged commit 4b932cf into release-harvester-v1.2 Apr 30, 2024
7 checks passed
@mergify mergify bot deleted the mergify/bp/release-harvester-v1.2/pr-995 branch April 30, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants