-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support-bundle-node-collection-timeout config #1041
Conversation
Signed-off-by: Jack Yu <jack.yu@suse.com>
SUPPORT_BUNDLE_TIMEOUT: 'support-bundle-timeout', | ||
SUPPORT_BUNDLE_EXPIRATION: 'support-bundle-expiration', | ||
SUPPORT_BUNDLE_IMAGE: 'support-bundle-image', | ||
SUPPORT_BUNDLE_NODE_COLLECTION_TIMEOUT: 'support-bundle-node-collection-timeout', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only added this one, the others are formatted.
[HCI_SETTING.OVERCOMMIT_CONFIG]: { kind: 'json', from: 'import' }, | ||
[HCI_SETTING.SUPPORT_BUNDLE_TIMEOUT]: {}, | ||
[HCI_SETTING.SUPPORT_BUNDLE_EXPIRATION]: {}, | ||
[HCI_SETTING.SUPPORT_BUNDLE_NODE_COLLECTION_TIMEOUT]: {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
This one will also be backported to v1.3. |
@a110605 you need to update harvester-webhook image as well. |
@a110605 Thanks for testing that part. Already created a PR for that harvester/harvester#5969, and tested it. You could use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as it has webhook validation.
Pull your image looks good on my local. ![]() |
@mergify backport release-harvester-v1.3 |
✅ Backports have been created
|
Signed-off-by: Jack Yu <jack.yu@suse.com> (cherry picked from commit cc2146f)
…v1.3/pr-1041 feat: add support-bundle-node-collection-timeout config (backport #1041)
Summary
PR Checklist
Fixes harvester/harvester#1646
Occurred changes and/or fixed issues
Add new
suppport-bundle-node-collection-timeout
setting.Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video