Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support-bundle-node-collection-timeout config #1041

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

Yu-Jack
Copy link
Collaborator

@Yu-Jack Yu-Jack commented Jun 5, 2024

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Fixes harvester/harvester#1646

Occurred changes and/or fixed issues

Add new suppport-bundle-node-collection-timeout setting.

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

@Yu-Jack Yu-Jack self-assigned this Jun 5, 2024
Signed-off-by: Jack Yu <jack.yu@suse.com>
SUPPORT_BUNDLE_TIMEOUT: 'support-bundle-timeout',
SUPPORT_BUNDLE_EXPIRATION: 'support-bundle-expiration',
SUPPORT_BUNDLE_IMAGE: 'support-bundle-image',
SUPPORT_BUNDLE_NODE_COLLECTION_TIMEOUT: 'support-bundle-node-collection-timeout',
Copy link
Collaborator Author

@Yu-Jack Yu-Jack Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added this one, the others are formatted.

[HCI_SETTING.OVERCOMMIT_CONFIG]: { kind: 'json', from: 'import' },
[HCI_SETTING.SUPPORT_BUNDLE_TIMEOUT]: {},
[HCI_SETTING.SUPPORT_BUNDLE_EXPIRATION]: {},
[HCI_SETTING.SUPPORT_BUNDLE_NODE_COLLECTION_TIMEOUT]: {},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@Yu-Jack
Copy link
Collaborator Author

Yu-Jack commented Jun 5, 2024

This one will also be backported to v1.3.

@a110605
Copy link

a110605 commented Jun 5, 2024

Does support-bundle-node-collection-timeout setting allow negative integer or given string ?
Since support-bundle-timeout has webhook validation for negative integer or given string

Screenshot_20240605_125900
Screenshot_20240605_125932
Screenshot_20240605_125950

@Yu-Jack
Copy link
Collaborator Author

Yu-Jack commented Jun 5, 2024

@a110605 you need to update harvester-webhook image as well.

@Yu-Jack
Copy link
Collaborator Author

Yu-Jack commented Jun 5, 2024

@a110605 Thanks for testing that part. Already created a PR for that harvester/harvester#5969, and tested it. You could use jk82421/harvester-webhook:v1.3.0.4 to test it first.

Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it has webhook validation.

@a110605
Copy link

a110605 commented Jun 5, 2024

@a110605 Thanks for testing that part. Already created a PR for that harvester/harvester#5969, and tested it. You could use jk82421/harvester-webhook:v1.3.0.4 to test it first.

Pull your image looks good on my local.

image

@Yu-Jack Yu-Jack merged commit cc2146f into harvester:master Jun 5, 2024
7 checks passed
@Yu-Jack
Copy link
Collaborator Author

Yu-Jack commented Jun 5, 2024

@mergify backport release-harvester-v1.3

Copy link

mergify bot commented Jun 5, 2024

backport release-harvester-v1.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 5, 2024
Signed-off-by: Jack Yu <jack.yu@suse.com>
(cherry picked from commit cc2146f)
torchiaf added a commit that referenced this pull request Jun 5, 2024
…v1.3/pr-1041

feat: add support-bundle-node-collection-timeout config (backport #1041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants