Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't install Harvester cloud provider in Rancher v2.7-head guest cluster configuration page #3506

Closed
TachunLin opened this issue Feb 20, 2023 · 12 comments
Assignees
Labels
area/dashboard Harvester/Rancher dashboard kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue reproduce/always Reproducible 100% of the time severity/needed Reminder to add a severity label and to remove this one severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact)
Milestone

Comments

@TachunLin
Copy link

Describe the bug

On rancher v2.7-head, in the RKE2 cluster provisioning page, we can't select Harvester cloud provider for the given Kubernetes version of v1.25.6, v1.24.10 and v1.23.6
image

To Reproduce
Steps to reproduce the behavior:

  1. Import Harvester to Rancher
  2. Create cloud credential
  3. Provision RKE2 cluster
  4. Check the Cloud provider setting drop down list

Expected behavior

Should be able to select Harvester cloud provider for the given Kubernetes version

Support bundle

Environment

  • Harvester ISO version: v1.1.2-rc1
  • Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): local kvm machine
  • Rancher version: v2.7-head (ab561bf)
  • Node driver version: v0.6.1

Additional context
Add any other context about the problem here.

@TachunLin TachunLin added kind/bug Issues that are defects reported by users or that we know have reached a real release severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact) area/rancher Rancher related issues reproduce/always Reproducible 100% of the time severity/needed Reminder to add a severity label and to remove this one labels Feb 20, 2023
@n313893254
Copy link

n313893254 commented Feb 20, 2023

Same as an issue 3389. The Harvester cloud provider can not select issue is caused by the version setting check: /v1/harvester/harvesterhci.io.settings/harvester-csi-ccm-versions.

The workaround is to update the setting default value or value to {"harvester-cloud-provider":">=0.0.1","harvester-csi-provider":">=0.0.1"}

The workaround is to change the Harvester server-version setting to v1.1.2.

image

@guangbochen
Copy link
Contributor

@n313893254 doesn't the upstream PR rancher/dashboard#8081 already address the issue?

@n313893254
Copy link

@guangbochen This PR is valid for official versions like v1.1.2, but no judgment is made for RC versions that have a suffix. The workaround is to change the Harvester server-version setting to v1.1.2.

@WuJun2016 WuJun2016 added the not-require/test-plan Skip to create a e2e automation test issue label Feb 21, 2023
@WuJun2016 WuJun2016 self-assigned this Feb 21, 2023
@WuJun2016 WuJun2016 added this to the v1.1.2 milestone Feb 21, 2023
@guangbochen guangbochen added area/dashboard Harvester/Rancher dashboard required-for-rc/v1.1.2 and removed area/rancher Rancher related issues labels Feb 21, 2023
@harvesterhci-io-github-bot
Copy link

harvesterhci-io-github-bot commented Feb 22, 2023

Pre Ready-For-Testing Checklist

* [ ] If labeled: require/HEP Has the Harvester Enhancement Proposal PR submitted?
The HEP PR is at:

  • Where is the reproduce steps/test steps documented?
    The reproduce steps/test steps are at:
  • Is there a workaround for the issue? If so, where is it documented?
    The workaround is at:
  • If labeled: area/ui Has the UI issue filed or ready to be merged?
    The UI issue/PR is at:

* [ ] If labeled: require/doc, require/knowledge-base Has the necessary document PR submitted or merged?
The documentation/KB PR is at:

  • If NOT labeled: not-require/test-plan Has the e2e test plan been merged? Have QAs agreed on the automation test case? If only test case skeleton w/o implementation, have you created an implementation issue?
    • The automation skeleton PR is at:
    • The automation test case PR is at:~

* [ ] If the fix introduces the code for backward compatibility Has a separate issue been filed with the label release/obsolete-compatibility?
The compatibility issue is filed at:

@irishgordo irishgordo self-assigned this Feb 22, 2023
@irishgordo
Copy link

irishgordo commented Feb 22, 2023

@n313893254 thanks for the workaround 😄
This looks good, I'll go ahead and close this out.

Validated on:

  • Harvester Version: v1.1.2-rc1
  • Rancher Version v2.7-head / v2.7-eb96417fb0fc75bbb5c4dde95aed949d6585239d-head

With the workaround of:

  • Navigate to Harvester "admin" preferences
  • Check boxes:
    • "Enable View in API"
    • "Show system Namespaces managed by Rancher"
    • "Enable Extension Developer features"
  • Navigate to Harvester -> Advanced -> Settings -> server-version -> View in API -> Edit (removing "-rc1") -> Send Request, validate 200

Then import Harvester to Rancher.
Validate current KDM Metadata for v2.7-head has latest drivers:

╭─mike at suse-workstation-team-harvester in ~
╰─○ curl https://releases.rancher.com/kontainer-driver-metadata/dev-v2.7/data.json | jq '.rke2.releases[] | select( .charts["harvester-csi-driver"]["version"] == "0.1.1500" ) | {"rke2-releases-rke2-version": .version, "rke2-releases-rke2-provided-harvester-csi-driver": .charts["harvester-csi-driver"]}'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 5311k  100 5311k    0     0  17.6M      0 --:--:-- --:--:-- --:--:-- 17.6M
{
  "rke2-releases-rke2-version": "v1.23.16+rke2r1",
  "rke2-releases-rke2-provided-harvester-csi-driver": {
    "repo": "rancher-rke2-charts",
    "version": "0.1.1500"
  }
}
{
  "rke2-releases-rke2-version": "v1.24.10+rke2r1",
  "rke2-releases-rke2-provided-harvester-csi-driver": {
    "repo": "rancher-rke2-charts",
    "version": "0.1.1500"
  }
}
{
  "rke2-releases-rke2-version": "v1.25.6+rke2r1",
  "rke2-releases-rke2-provided-harvester-csi-driver": {
    "repo": "rancher-rke2-charts",
    "version": "0.1.1500"
  }
}

Validate Harvester is not greyed out and can be installed:
Screenshot from 2023-02-22 13-42-01
Screenshot from 2023-02-22 13-41-29
Screenshot from 2023-02-22 13-41-07
Screenshot from 2023-02-22 13-40-44
Screenshot from 2023-02-22 13-38-46
Screenshot from 2023-02-22 13-38-22
Screenshot from 2023-02-22 13-37-54
Screenshot from 2023-02-22 13-37-29
Screenshot from 2023-02-22 13-54-39

@WuJun2016
Copy link
Contributor

@irishgordo This problem has been fixed in the rancher 2.7-head, and it does not need to use the workaround method to test. Can you help me use the latest rancher to test it? thank you

@WuJun2016
Copy link
Contributor

I'll reopen this issue, thank you

@WuJun2016 WuJun2016 reopened this Feb 23, 2023
@irishgordo
Copy link

@WuJun2016 - I can help validate with Rancher v2.7-head 😄 and not implementing the previous workaround - I'll work on validating this now

@irishgordo
Copy link

@WuJun2016
This looks good on Rancher v2.7-head ( v2.7-7c60dc0856e19c278d520946d4d2e7ea2b86d70f-head ) with Harvester v1.1.2-rc1.
No workaround was implemented, so the server-version was left un-touched 😄 .

Screenshot from 2023-02-22 18-18-51
Screenshot from 2023-02-22 18-10-27
Screenshot from 2023-02-22 18-10-04
Screenshot from 2023-02-22 18-09-39

Should I go ahead and close this out 😄 ?

@WuJun2016
Copy link
Contributor

@irishgordo Yes, you can close the issue. Thank you for your verification.

@irishgordo
Copy link

You're welcome! Glad I could help! 😄 Thanks again for pre-release comparison logic fix @WuJun2016 !

@guangbochen
Copy link
Contributor

guangbochen commented Mar 17, 2023

This will be fixed in the upcoming Rancher v2.7.2, as a temp workaround, you can modify the related setting in the Harvester via:

$ kubectl edit settings.harvesterhci.io harvester-csi-ccm-versions

# and patch the default value as below
default: '{"harvester-cloud-provider":">=0.0.1 <0.2.0","harvester-csi-provider":">=0.0.1 <0.2.0"}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Harvester/Rancher dashboard kind/bug Issues that are defects reported by users or that we know have reached a real release not-require/test-plan Skip to create a e2e automation test issue reproduce/always Reproducible 100% of the time severity/needed Reminder to add a severity label and to remove this one severity/2 Function working but has a major issue w/o workaround (a major incident with significant impact)
Projects
None yet
Development

No branches or pull requests

6 participants