-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove mount logic in harvester #4910
Conversation
953d8a0
to
66c69f0
Compare
5a0b58d
to
0992ded
Compare
Signed-off-by: PoAn Yang <poan.yang@suse.com>
0992ded
to
4fe4ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question for restore from VM snapshot, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, also tested all test cases related to the snapshot/backup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all testing cases work as expected. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
@mergify backport v1.3 |
✅ Backports have been created
|
@mergify backport v1.2 |
✅ Backports have been created
|
Solution:
LH introduces VolumeAttachment CRD after v1.5. It can automatically attach/detach volume when there is a request from LH API / controller / CSI. We can just leverage LH mechanism and remove our implementation.
Related Issue:
#4907
Test plan:
Setup
Case 1: snapshot can work on a stopped VM.
Case 2: restore a snapshot from detached volumes can work.
Case 3: backup can work on a stopped VM.
Case 4: race condition doesn't break VMBackup.
Case 5: restore a backup from detached volumes can work.