refactor: remove mount logic in harvester (backport #4910) #5854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
LH introduces VolumeAttachment CRD after v1.5. It can automatically attach/detach volume when there is a request from LH API / controller / CSI. We can just leverage LH mechanism and remove our implementation.
Related Issue:
#4907, #5853, #5841
Test plan:
Setup
Case 1: snapshot can work on a stopped VM.
Case 2: restore a snapshot from detached volumes can work.
Case 3: backup can work on a stopped VM.
Case 4: race condition doesn't break VMBackup.
Case 5: restore a backup from detached volumes can work.
This is an automatic backport of pull request #4910 done by [Mergify](https://mergify.com).