check timestamps before waiting for agent rollout #5698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should address: #5690 |
|
@starbops The fix avoid the failure of wait_rollout and https://github.com/harvester/harvester/blob/8958ebee30387c8591eeb17ddf60e178517e9de3/package/upgrade/upgrade_manifests.sh#L1310C1-L1311C1 will be called. |
starbops
reviewed
Apr 29, 2024
starbops
approved these changes
Apr 29, 2024
FrankYang0529
approved these changes
Apr 29, 2024
|
@Mergifyio backport v1.2 v1.3 |
🛑 Command
|
|
@Mergifyio backport v1.2 v1.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit cc1c2ad) # Conflicts: # package/upgrade/upgrade_manifests.sh
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit cc1c2ad)
This was referenced Apr 29, 2024
ibrokethecloud
added a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit cc1c2ad) fixed rebase conflicts
starbops
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit cc1c2ad)
starbops
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit cc1c2ad) fixed rebase conflicts
bk201
pushed a commit
to bk201/harvester
that referenced
this pull request
May 2, 2024
(cherry picked from commit cc1c2ad) fixed rebase conflicts
bk201
pushed a commit
that referenced
this pull request
May 2, 2024
(cherry picked from commit cc1c2ad) fixed rebase conflicts
bk201
pushed a commit
to bk201/harvester
that referenced
this pull request
May 23, 2024
(cherry picked from commit cc1c2ad)
bk201
pushed a commit
that referenced
this pull request
May 24, 2024
(cherry picked from commit cc1c2ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
PR attempts to address random upgrade fails where the upgrade fails due to the following error:
This is caused by a delay in rollout of fleet-agent, where the rollout happens when the check for fleet-agent rollout status is running, and deployment gets recreated.
Solution:
The fix attempts to use original fleet-agent creation timestamp before fleet cluster object is patched, and ensures new fleet-agent deployment has a newer creation timestamp before rollout status is checked.
Related Issue:
Test plan: