WIP: Harvester load balancer enhancement #8
Conversation
yaocw2020
changed the title
yaocw2020
force-pushed
the
enhancement
branch
4 times, most recently
from
2a11e16
to
7395c59
Compare
yaocw2020
changed the title
yaocw2020
force-pushed
the
enhancement
branch
2 times, most recently
from
bc82dd8
to
66f3219
Compare
| } | ||
| logrus.Infof("VMI %s has been changed", vmi.Name) | ||
|
|
||
| lbs, err := h.lbCache.List("", labels.Everything()) |
There was a problem hiding this comment.
only list ! lbv1.Cluster or lbv1.VM will be efficiency
| return nil, nil | ||
| } | ||
|
|
||
| lbs, err := h.lbCache.List("", labels.Everything()) |
|
|
||
| for _, lb := range lbs { | ||
| // remove the backend server from the load balancers | ||
| if err := h.removeServerFromLB(vmi, lb); err != nil { |
There was a problem hiding this comment.
re-use matchBackendServers to check if this vmi is in the list at first ?
potential efficiency problem here:
(1) the vmi may have no relationship with any lb, but all lb (all endpoints) will be checked; if later m.endpointSliceCache.Get(lb.Namespace, lb.Name) fail, it will return error, but this lb may be irrelevant at all
(2) when there are many lbs...
| return nil, err | ||
| } | ||
|
|
||
| // add or update the backend server to the matched load balancer |
There was a problem hiding this comment.
vmi changes frequently; for most of the time, it is not related to lb
the lb checks vmi via iterating endpointslice, each time
it seems need a fast way, e.g. lb looks record info of vmi (e.g. id, ip), to have a one step match check
pkg/controller/ippool/controller.go
Outdated
| } | ||
|
|
||
| if ipPool.Spec.Ranges == nil || len(ipPool.Spec.Ranges) == 0 { | ||
| return nil, fmt.Errorf("invalid ip pool, range could not be empty") |
There was a problem hiding this comment.
As a controller, this file lacks of essential log
yaocw2020
force-pushed
the
enhancement
branch
4 times, most recently
from
918cd2a
to
c55533a
Compare
yaocw2020
force-pushed
the
enhancement
branch
3 times, most recently
from
82d0c86
to
fd49f07
Compare
yaocw2020
force-pushed
the
enhancement
branch
2 times, most recently
from
7f65b07
to
a82e037
Compare
yaocw2020
force-pushed
the
enhancement
branch
2 times, most recently
from
24163c1
to
044ecd8
Compare
yaocw2020
force-pushed
the
enhancement
branch
2 times, most recently
from
10860cc
to
0f59a4f
Compare
yaocw2020
changed the title
|
Need to update vendor after dependency PRs merged. |
- Add IP Pool module to support ipam for the load balancer - Support two workload type load balancer, including VM and cluster
|
close because replaced by PR #13. |
Related issue:
harvester/harvester#1762
harvester/harvester#1580
design document:
harvester/harvester#1913
Dependency:
harvester/harvester#3776
harvester/webhook#3