New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rtl issue take 2 #1159
Fix rtl issue take 2 #1159
Conversation
single and for active dropdowns.
@kenearley nice work. This made me realize we could simplify some code a bit by using a generic @mlharvest there are some css changes here, but I don't think they're super impactful. Mind taking a quick gander? This is good to go once you guys sign off. |
Quick glance everything looks fine. Question, why is 9000px better/different than 9999px? personal preference? |
It just wasn't consistent. Makes it easier to do search if we stick to one number that represents 'move it way off the page'. I'm cool with whatever number. |
I'm happy with this. |
Ok cool go with 9000. But in harvestapp/gh I usually use 9999 because its faster to hit four 9's and it's further you can go in four characters 🐎 |
@mlharvest Done! |
…to fix-rtl-issue-take-2
Conflicts: chosen/chosen.jquery.min.js chosen/chosen.proto.min.js
I suck at merging. |
This fixes the Right To Left scrollbar issue
Why does it need to be moved off the screen rather than hidden? |
@andriijas Good question. Here's an explanation given by @pfiller. |
@pfiller This builds upon the idea in this PR #1096 (comment) except it's toggling a css class to do the positioning.
left: -9000px
left: 9000px
cc: @stof, @ido-ran, @krembo99