Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when using jQuery & Prototype at the same time #1168

Merged
merged 1 commit into from Apr 26, 2013
Merged

Fix issue when using jQuery & Prototype at the same time #1168

merged 1 commit into from Apr 26, 2013

Conversation

pfiller
Copy link
Contributor

@pfiller pfiller commented Apr 26, 2013

@kenearley

An easy existential operator addition fixes #1165.

@pfiller pfiller mentioned this pull request Apr 26, 2013
Closed
@kenearley
Copy link

It seems strange to have any library specific code in AbstractChosen. Other than that, it looks good to me. :shipit:

@pfiller
Copy link
Contributor Author

pfiller commented Apr 26, 2013

I agree that the jQuery/Prototype code in here is not ideal (though that got added a few PRs back). That fallback actually only gets called in IE8 (everything else hits window.computedStyle) so I decided to keep the method in one place.

We can revisit that choice if it becomes a problem.

@kenearley
Copy link

Good enough for me.

pfiller added a commit that referenced this pull request Apr 26, 2013
@pfiller
Merge pull request #1168 from harvesthq/fix-for-1165
b374da6 
Fix issue when using both jQuery & Prototype
@pfiller pfiller merged commit b374da6 into master Apr 26, 2013
@pfiller pfiller deleted the fix-for-1165 branch April 26, 2013 16:50
pfiller added a commit that referenced this pull request May 2, 2013
@pfiller
Update to version 0.9.14
f63dd0d 
Fixes bug with Isolated Scrolling #1186
Remove unused get_side_border_padding #1169
Fix issue when using both jQuery & Prototype #1168
Fix choices_click method #1163
Isolate Chosen Scrolling #1155
Fix Right-to-Left scrollbar issue #1159
Add support for labels #1152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prototype version breaks if jQuery is also available (maybe just IE8)
2 participants
@pfiller @kenearley