Extend mobile browser detection #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I question is whether the tests should really be case-insensitive. I would lean towards them not being. Maybe it doesn't make much difference. |
| if /iP(od|hone)/i.test(window.navigator.userAgent) | ||
| return false | ||
| if /Android/i.test(window.navigator.userAgent) | ||
| return false if /Mobile/i.test(window.navigator.userAgent) | ||
| if /IEMobile/i.test(navigator.userAgent) |
There was a problem hiding this comment.
Looks like you're missing a window. on all of these conditions.
There was a problem hiding this comment.
It would still work, would it not? window being the global object and all. But I'll add it for consistency.
|
This looks good to me, but hopefully we can get a 👍 from a more qualified @harvesthq/chosen-developers -- maybe @koenpunt if we're lucky? |
|
I'm not aware of the actual user agent strings, but this seems good to me |
tjschuck
added a commit
that referenced
this pull request
Oct 6, 2015
Extend mobile browser detection
|
Thanks @tremby and @StephKoenig (and @koenpunt)! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the existing detections of Android and IOS, detect Windows Phone, IE Mobile, Blackberry and BB10.
As discussed in #1848 and #2439