Added "Add New" support as requested in issue #5 #316
Conversation
|
The callback should receive the value of the field |
| @@ -630,6 +634,10 @@ | |||
| if (this.result_highlight) { | |||
| high = this.result_highlight; | |||
| high_id = high.attr("id"); | |||
| if (high.hasClass("new-result")) { | |||
| this.options.new_item_callback(); | |||
There was a problem hiding this comment.
Is this where you(@stof) would like to pass the value of the field? ie
this.options.new_item_callback(@search_field.val())
Couldn't you get that already in the callback with $(this).val()
There was a problem hiding this comment.
well, it would be easier IMO to pass the value.
Thus, this in the callback will not refer to the field with the way you call it currently AFAIS.
There was a problem hiding this comment.
this refers to the settings object. Also, .val() returns the value of the <option> not it's content. How can I get the actual entered content?
There was a problem hiding this comment.
I mean this inside the callback for the guy writing the callback. Using $(this).val() in the callback will not work as the this in the callback will refer to the root context (i.e. `window), not to the`` element
|
You also need to implement it in the Prototype version. And I still think that passing the value would be easier for the end-user. Let's see what @pfiller think about it. |
|
UI review: Overall I like having an "Add new" option better than the approach taken in #326. It's more discoverable and more consistent. However I would suggest these changes:
This would require updating the option whenever the input changes, but would improve usability IMO |
|
Will this, #326, or any other approach to add a new value be included soon? |
|
+1 Would love to see the feature implemented. Any hopes of this happening in the near future? |
|
@dcalhoun See my pull request (with docs) at #166 and see my branch at https://github.com/koenpunt/chosen. Just merged harvesthq/master back into it. |
|
|
||
|
|
||
| if high.hasClass "new-result" | ||
| @options.new_item_callback(evt) |
There was a problem hiding this comment.
the context for the callback should probably be changed to something more useful than this.options
|
Thanks @masonforest I'm sorry it took so long to review this. There are several other pull requests that address adding new options and I wanted to give them all a fair shake. To my eyes, it looks as though #166 and #320 are more complete options so I'm going to focus on those. Feel free to weigh in on those threads. |
Added "Add New" support as requested in issue #5