Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

util/build: rationalize json files #12

Closed
2 of 4 tasks
Shamar opened this issue Aug 12, 2015 · 6 comments
Closed
2 of 4 tasks

util/build: rationalize json files #12

Shamar opened this issue Aug 12, 2015 · 6 comments

Comments

@Shamar
Copy link

Shamar commented Aug 12, 2015

Since we use json files to guide the build, we should give them a bit more love:

  • replace .. inclusions with absolute paths (/ is the $HARVEY dir): so we can move folders easily
  • inherit CFlags whenever possible
  • make architecture-dependent paths depend on $ARCH (see core.json).
    Requires little changes to build.go
  • use environment variables in Pre/Post scripts when appropriate (eg here and here)
@sevki
Copy link
Member

sevki commented Aug 13, 2015

on this

@Shamar Shamar assigned Shamar and unassigned Shamar Aug 14, 2015
@Shamar
Copy link
Author

Shamar commented Aug 14, 2015

@sevki, if you are still working on this, give a look at this pending CL.

I have a small task pending on Cflags (enable extensive debug flags everywhere as I need them for #5), but to avoid Merge Conflict on Gerrit, I can send you a pull request in a branch you prefer.

Shamar added a commit that referenced this issue Aug 15, 2015
util/build: code cleanup and improvements, see #8 and #12
44115b2 
- introduced sh(*exec.Cmd) that pipes build commands to a shell
  so that Coverity's tools can intercept calls to exec(2) via
  their $LD_PRELOADed proxy (see #8)
- renamed fail(err) in failOn(err) and used it whenever possible
- evaluate /$ARCH/ instead of using /amd64/ in paths
- adjust1: eval environment variables (see #12)

Change-Id: I8811c827fe38b2531dcad87466a8558be5002561
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich added a commit that referenced this issue Aug 15, 2015
@rminnich @gerritforge-ltd
Merge "util/build: code cleanup and improvements, see #8 and #12"
cbb38aa
@Shamar
Copy link
Author

Shamar commented Aug 17, 2015

@sevki in my debug-everything branch you can see the debugging options that I added.

@sevki
Copy link
Member

sevki commented Aug 17, 2015

@Shamar cool

@Shamar
Copy link
Author

Shamar commented Aug 20, 2015

In b8cfdea @rminnich centralized Cflags in amd64/include/cflags.json.

Shamar added a commit that referenced this issue Aug 22, 2015
cflags.json: sorted; more debug symbols for gdb. see #12
ec22307 
Change-Id: I978252232f67e2bf3d188f586a4d08339f0de342
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich added a commit that referenced this issue Aug 22, 2015
@rminnich @gerritforge-ltd
Merge "cflags.json: sorted; more debug symbols for gdb. see #12"
a81c456
Shamar added a commit that referenced this issue Nov 7, 2015
util/build: expand environment variables in Cflags, see #12
7582e48 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Shamar added a commit that referenced this issue Nov 7, 2015
@gerritforge-ltd
Merge "util/build: expand environment variables in Cflags, see #12"
b033f72
Shamar added a commit that referenced this issue Dec 2, 2015
util/build: expand environment variables in SourceFiles and SourceFil…
83bbe2c 
…esCmd, see #12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Shamar added a commit that referenced this issue Dec 2, 2015
libc: use $ARCH in jsons, see #12
48d63c3 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Shamar added a commit that referenced this issue Dec 2, 2015
kernel: use $ARCH in jsons, see #12
44ee58e 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Shamar added a commit that referenced this issue Dec 2, 2015
sys/src/cmd: use $ARCH in jsons, see #12
dffe80c 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Shamar added a commit that referenced this issue Dec 2, 2015
libthread: use $ARCH in jsons, see #12
fea9053 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
@elbing
Copy link
Member

elbing commented Jan 22, 2016

A new build tool is in progress.

@elbing elbing closed this as completed Jan 22, 2016
@floren floren mentioned this issue Mar 30, 2017
Closed
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in Cflags, see Harvey-OS#12
39561fd 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in SourceFiles and SourceFil…
c39334c 
…esCmd, see Harvey-OS#12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libc: use $ARCH in jsons, see Harvey-OS#12
a67a7a8 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
kernel: use $ARCH in jsons, see Harvey-OS#12
c22a0dc 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
sys/src/cmd: use $ARCH in jsons, see Harvey-OS#12
d5aa9ff 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libthread: use $ARCH in jsons, see Harvey-OS#12
60483dc 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: code cleanup and improvements, see Harvey-OS#8 and Harvey…
1133a7f 
…-OS#12

- introduced sh(*exec.Cmd) that pipes build commands to a shell
  so that Coverity's tools can intercept calls to exec(2) via
  their $LD_PRELOADed proxy (see Harvey-OS#8)
- renamed fail(err) in failOn(err) and used it whenever possible
- evaluate /$ARCH/ instead of using /amd64/ in paths
- adjust1: eval environment variables (see Harvey-OS#12)

Change-Id: I8811c827fe38b2531dcad87466a8558be5002561
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
cflags.json: sorted; more debug symbols for gdb. see Harvey-OS#12
6a79e33 
Change-Id: I978252232f67e2bf3d188f586a4d08339f0de342
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in Cflags, see Harvey-OS#12
3e4fb87 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in SourceFiles and SourceFil…
0615360 
…esCmd, see Harvey-OS#12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libc: use $ARCH in jsons, see Harvey-OS#12
306489e 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
kernel: use $ARCH in jsons, see Harvey-OS#12
889be44 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
sys/src/cmd: use $ARCH in jsons, see Harvey-OS#12
730487c 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libthread: use $ARCH in jsons, see Harvey-OS#12
b7e1335 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: code cleanup and improvements, see Harvey-OS#8 and Harvey…
be366f8 
…-OS#12

- introduced sh(*exec.Cmd) that pipes build commands to a shell
  so that Coverity's tools can intercept calls to exec(2) via
  their $LD_PRELOADed proxy (see Harvey-OS#8)
- renamed fail(err) in failOn(err) and used it whenever possible
- evaluate /$ARCH/ instead of using /amd64/ in paths
- adjust1: eval environment variables (see Harvey-OS#12)

Change-Id: I8811c827fe38b2531dcad87466a8558be5002561
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
cflags.json: sorted; more debug symbols for gdb. see Harvey-OS#12
5164a79 
Change-Id: I978252232f67e2bf3d188f586a4d08339f0de342
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in Cflags, see Harvey-OS#12
d17296e 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
util/build: expand environment variables in SourceFiles and SourceFil…
7fa2b11 
…esCmd, see Harvey-OS#12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libc: use $ARCH in jsons, see Harvey-OS#12
d73bce5 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
kernel: use $ARCH in jsons, see Harvey-OS#12
fc9c586 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
sys/src/cmd: use $ARCH in jsons, see Harvey-OS#12
a97737f 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
rminnich pushed a commit to rminnich/harvey that referenced this issue Jan 5, 2018
@Shamar @rminnich
libthread: use $ARCH in jsons, see Harvey-OS#12
ad27566 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: code cleanup and improvements, see Harvey-OS#8 and Harvey…
c7583ee 
…-OS#12

- introduced sh(*exec.Cmd) that pipes build commands to a shell
  so that Coverity's tools can intercept calls to exec(2) via
  their $LD_PRELOADed proxy (see Harvey-OS#8)
- renamed fail(err) in failOn(err) and used it whenever possible
- evaluate /$ARCH/ instead of using /amd64/ in paths
- adjust1: eval environment variables (see Harvey-OS#12)

Change-Id: I8811c827fe38b2531dcad87466a8558be5002561
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
cflags.json: sorted; more debug symbols for gdb. see Harvey-OS#12
bb0f1a3 
Change-Id: I978252232f67e2bf3d188f586a4d08339f0de342
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: expand environment variables in Cflags, see Harvey-OS#12
d602316 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: expand environment variables in SourceFiles and SourceFil…
fbcfdb0 
…esCmd, see Harvey-OS#12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
libc: use $ARCH in jsons, see Harvey-OS#12
0261c9c 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
kernel: use $ARCH in jsons, see Harvey-OS#12
b4d5a1f 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
sys/src/cmd: use $ARCH in jsons, see Harvey-OS#12
1314319 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
libthread: use $ARCH in jsons, see Harvey-OS#12
35923af 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: code cleanup and improvements, see Harvey-OS#8 and Harvey…
f9d2055 
…-OS#12

- introduced sh(*exec.Cmd) that pipes build commands to a shell
  so that Coverity's tools can intercept calls to exec(2) via
  their $LD_PRELOADed proxy (see Harvey-OS#8)
- renamed fail(err) in failOn(err) and used it whenever possible
- evaluate /$ARCH/ instead of using /amd64/ in paths
- adjust1: eval environment variables (see Harvey-OS#12)

Change-Id: I8811c827fe38b2531dcad87466a8558be5002561
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
cflags.json: sorted; more debug symbols for gdb. see Harvey-OS#12
a157e5d 
Change-Id: I978252232f67e2bf3d188f586a4d08339f0de342
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: expand environment variables in Cflags, see Harvey-OS#12
1c2d9f2 
Change-Id: Ic9c6d06b8bf957895d472a1ce09767cdb27998b7
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
util/build: expand environment variables in SourceFiles and SourceFil…
f3e5310 
…esCmd, see Harvey-OS#12

Change-Id: I6070b7f001f27021175f732523041a6a515f1734
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
libc: use $ARCH in jsons, see Harvey-OS#12
a90e320 
Change-Id: If8e9460c42c8c77ae843bed88589b2f36f43a696
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
kernel: use $ARCH in jsons, see Harvey-OS#12
e1c2793 
Change-Id: I230d279074d24f483027886634fc40aa774bef58
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
sys/src/cmd: use $ARCH in jsons, see Harvey-OS#12
61f84e9 
Change-Id: I605d83868cdb96b3697c4a0c984b412c6fba926a
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
gmacd pushed a commit to gmacd/harvey that referenced this issue Jan 8, 2018
@Shamar @gmacd
libthread: use $ARCH in jsons, see Harvey-OS#12
1040eca 
Change-Id: I1734b3d8793c37292419670de79ee54b91e0a339
Signed-off-by: Giacomo Tesio <giacomo@tesio.it>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Shamar @sevki @elbing