Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not meddle with the PyQt namespace #57

Closed
sbourdeauducq opened this issue Dec 10, 2015 · 4 comments
Closed

Do not meddle with the PyQt namespace #57

sbourdeauducq opened this issue Dec 10, 2015 · 4 comments

Comments

@sbourdeauducq
Copy link

i.e. remove this:
https://github.com/harvimt/quamash/blob/master/quamash/__init__.py#L52
@harvimt harvimt closed this as completed Dec 14, 2015
@sbourdeauducq
Copy link
Author

Well, the hack is still there. Is it absolutely necessary?

@harvimt
Copy link
Owner

harvimt commented Dec 15, 2015

No. It's been fixed in another branch for a while.

Also it's like the least ugly hack in quamash.

On Mon, Dec 14, 2015 at 4:17 PM, Sébastien Bourdeauducq <
notifications@github.com> wrote:

Well, the hack is still there. Is it absolutely necessary?

—
Reply to this email directly or view it on GitHub
#57 (comment).

@sbourdeauducq
Copy link
Author

Can you please point to the branch you are referring to?

@harvimt
Copy link
Owner

harvimt commented Dec 15, 2015

depinject5realz I think. It's in a PR, and it needs to be rebased off
master.

On Mon, Dec 14, 2015 at 5:54 PM, Sébastien Bourdeauducq <
notifications@github.com> wrote:

Can you please point to the branch you are referring to?

—
Reply to this email directly or view it on GitHub
#57 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@harvimt @sbourdeauducq