CI fixes #74
Merged
CI fixes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
hrmm. well it still fails appveyor, but it's an improvement, so I'll merge it. I'm considering turning down the docstring checks though... the one on the exception handler is a little redundant (especially considering the function's name) |
|
I will add pytest-timeout to catch the hanging test in a separate PR. |
|
Last I checked py.test timeouts didn't support windows (because it uses
os.fork), but I could be mistaken, or there could be a py.test plugin that
works on windows.
…On Wed, Aug 9, 2017 at 10:55 PM, Korijn van Golen ***@***.***> wrote:
I will add pytest-timeout to catch the hanging test in a separate PR.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#74 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHRQh1Cw1MNCuOJxB5FIOyRER-tAaPqks5sWptcgaJpZM4Oxqez>
.
|
This was referenced Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_regression_bug13on AppVeyor since it is failing. Someone else can follow up later with a fix. See AppVeyor test suite fails #73 to track progress on this work item.