python 3.6?

[Korijn]

Any efforts going on to support python 3.6? Are you accepting PRs?

[harvimt]

Is that a question? This package only works with Python 3.4 or greater.

…

On Aug 8, 2017 13:41, "Korijn van Golen" ***@***.***> wrote: — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#72>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHRQtnNvl188F2ssasR9Ns0TEUxo6KRks5sWMfvgaJpZM4OxQ_1> .

[Korijn]

The README doesn't state that 3.6 is supported by this library. So I decided to ask if it is the case.

If it is merely outdated information I can open a PR to correct it for you?

[harvimt]

ugh. this is one of those times where having a working test suite would be good, because then we could re-run the test suite on 3.6 and then we'd know it works.

It should work just fine on 3.6 though.

[Korijn]

Fixing Travis seems simple enough; just two flake8 errors.

./quamash/_unix.py:220:1: E305 expected 2 blank lines after class or function definition, found 1
./quamash/__init__.py:172:1: E305 expected 2 blank lines after class or function definition, found 1

From https://travis-ci.org/harvimt/quamash/jobs/188431070

Is there a big issue holding you back that I'm overlooking? If it's just some linting I'll fix it for you.

[Korijn]

test_regression_bug13 fails on AppVeyor I see: https://ci.appveyor.com/project/harvimt/quamash

This also seems fixable to me.

[harvimt]

Last I checked Travis was failing to install PyQt, but I guess hadn't looked in a while? The Appveyor tests are another thing, getting all the tests to pass on windows would be good (but not necessary to declare compat with python 3.6)

…

On Tue, Aug 8, 2017 at 10:40 PM, Korijn van Golen ***@***.***> wrote: Lots of errors on AppVeyor I see: https://ci.appveyor.com/ project/harvimt/quamash Is that the big issue? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHRQpaXQXEYLz8-XlHpViUVwbfzjC7Yks5sWUY7gaJpZM4OxQ_1> .

[Korijn]

I opened PR #74 to get CI to pass first.

Once that is merged I will open another PR to enable Python 3.6.