Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.6? #72

Closed
Korijn opened this issue Aug 8, 2017 · 7 comments
Closed

python 3.6? #72

Korijn opened this issue Aug 8, 2017 · 7 comments

Comments

@Korijn
Copy link
Contributor

Korijn commented Aug 8, 2017

Any efforts going on to support python 3.6? Are you accepting PRs?

@Korijn Korijn changed the title python 3 python 3.6? Aug 8, 2017
@harvimt
Copy link
Owner

harvimt commented Aug 8, 2017 via email

@Korijn
Copy link
Contributor Author

Korijn commented Aug 9, 2017

The README doesn't state that 3.6 is supported by this library. So I decided to ask if it is the case.

If it is merely outdated information I can open a PR to correct it for you?

@harvimt
Copy link
Owner

harvimt commented Aug 9, 2017

ugh. this is one of those times where having a working test suite would be good, because then we could re-run the test suite on 3.6 and then we'd know it works.

It should work just fine on 3.6 though.

@Korijn
Copy link
Contributor Author

Korijn commented Aug 9, 2017

Fixing Travis seems simple enough; just two flake8 errors.

./quamash/_unix.py:220:1: E305 expected 2 blank lines after class or function definition, found 1
./quamash/__init__.py:172:1: E305 expected 2 blank lines after class or function definition, found 1

From https://travis-ci.org/harvimt/quamash/jobs/188431070

Is there a big issue holding you back that I'm overlooking? If it's just some linting I'll fix it for you.

@Korijn
Copy link
Contributor Author

Korijn commented Aug 9, 2017

test_regression_bug13 fails on AppVeyor I see: https://ci.appveyor.com/project/harvimt/quamash

This also seems fixable to me.

@harvimt
Copy link
Owner

harvimt commented Aug 9, 2017 via email

@Korijn
Copy link
Contributor Author

Korijn commented Aug 9, 2017

I opened PR #74 to get CI to pass first.

Once that is merged I will open another PR to enable Python 3.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants