This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fixes #816 - bill committee meeting autocomplete shouldn't take so long to load #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e so long to load
alonisser
reviewed
Jan 15, 2017
| @@ -965,7 +965,7 @@ def committee_meeting_auto_complete(request): | |||
|
|
|||
| optional_committee_meetings = CommitteeMeeting.objects.filter( | |||
| Q(date_string__icontains=q) | Q(topics__icontains=q) | |||
| ) | |||
| )[:10] | |||
There was a problem hiding this comment.
But does't this remove meetings that should be available? maybe a better strategy would be using topics only when q is a topic, or prefetch_related topics or try to give more information for the q so the basic query would have less results and be more precise
There was a problem hiding this comment.
not sure I understand, if you could send an example from other places that would be helpful..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating issues