-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn "met X" adult/minor quetsion optional [0.5h] #331
Comments
Left two comments on the commit: 43c1b67 |
the placeholder was changed, but I can't click enter with no values on both quetsions |
@akariv now, on first round, things look and behave as expected: when I enter BTW, did I just submit two reports for the same user by correcting my answer? (two "would send" in the console) (a fuller check, of possible combinations, will take place later) |
|
|
Can you share the log with the 'household' info?
…On Mon, Jun 1, 2020 at 9:31 PM noamoss ***@***.***> wrote:
@akariv <https://github.com/akariv>
1. I am a reproter, 20 years old living with 1 (myself) adult person
(in the age of 18+). I reported meeting another 1 adult person, but the
submitted value is 2:
[image: תמונה]
<https://user-images.githubusercontent.com/3581741/83441478-4548ec00-a44f-11ea-995a-be0cf9539c07.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAY5POIBWK5DB4LINMRX3RUPXZVANCNFSM4NDSCZAA>
.
|
The two would sends is indeed an issue - fixed here:
https://travis-ci.org/github/hasadna/avid-covider/builds/693563518
…On Mon, Jun 1, 2020 at 9:34 PM Adam Kariv ***@***.***> wrote:
Can you share the log with the 'household' info?
On Mon, Jun 1, 2020 at 9:31 PM noamoss ***@***.***> wrote:
> @akariv <https://github.com/akariv>
>
> 1. I am a reproter, 20 years old living with 1 (myself) adult person
> (in the age of 18+). I reported meeting another 1 adult person, but the
> submitted value is 2:
>
> [image: תמונה]
> <https://user-images.githubusercontent.com/3581741/83441478-4548ec00-a44f-11ea-995a-be0cf9539c07.png>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#331 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AACAY5POIBWK5DB4LINMRX3RUPXZVANCNFSM4NDSCZAA>
> .
>
|
|
Roie is checking the sanity table from the last comment. Will update here soon. Meanwhile, regardig your last update:
Tried to reproduce - when I click the "fix/correct" butotn, I fly all the way back to the begnning for the chat - to choose the reporter... was that done on purpose? |
If you try.to.correct a previous reporters answer after you started a new reporter, you will restart with the new reporter's answers. |
|
after finishging the current report, before starting (choosing) the next reporter |
yes, in that case you will restart with the reporter choice - as the
previous report was already sent and cannot be amended any more.
…On Mon, Jun 1, 2020 at 11:56 PM noamoss ***@***.***> wrote:
@akariv <https://github.com/akariv>
If you try.to.correct a previous reporters answer after you started a new
reporter, you will restart with the new reporter's answers.
after finishging the current report, before starting (choosing) the next
reporter
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAY5N54VIN65YKWK4O5MLRUQIXNANCNFSM4NDSCZAA>
.
|
part of #308 :
following a talk with Smadar, we should turn both questions into optional (not mandatory).
The text was updated successfully, but these errors were encountered: