refactor: add no-unsafe-call lint and improve types
#461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoamGaash
approved these changes
Feb 7, 2024
| }) | ||
|
|
||
| const res = relevant.reduce((acc: Operator[], name: string): Operator[] => { | ||
| return agencyMap.has(name) | ||
| ? [...acc, { name, id: agencyMap.get(name)?.operator_ref.toString() }] | ||
| ? [...acc, { name, id: (agencyMap.get(name) as Agency).operator_ref.toString() }] |
There was a problem hiding this comment.
If we leave it as is it won't be assignable:
Type '{ name: string; id: string | undefined; }[]' is not assignable to type 'Operator[]'.
Type '{ name: string; id: string | undefined; }' is not assignable to type 'Operator'.
Types of property 'id' are incompatible.
Type 'string | undefined' is not assignable to type 'string'.
Type 'undefined' is not assignable to type 'string'.
There was a problem hiding this comment.
Suggested change
| ? [...acc, { name, id: (agencyMap.get(name) as Agency).operator_ref.toString() }] | |
| ? [...acc, { name, id: (agencyMap.get(name)!).operator_ref.toString() }] |
will tell it that it can't be undefined
NoamGaash
changed the title
no-unsafe-call lint and improve types
Co-authored-by: Noam Gaash <noam.gaash@gmail.com>
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed linting issues after removing:
'@typescript-eslint/no-unsafe-call': 'off'
issue #450
What I did:
eslint-disable-next-line @typescript-eslint/no-unsafe-callfor two lines in the utils.ts file due to special cases.There might be a need to change the config to exempt js files from eslint
@NoamGaash
screenshots