Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make us SEO compatible #745

Open
4 of 6 tasks
NoamGaash opened this issue May 9, 2024 · 13 comments
Open
4 of 6 tasks

Make us SEO compatible #745

NoamGaash opened this issue May 9, 2024 · 13 comments
Assignees
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers usability

Comments

@NoamGaash
Copy link
Member

NoamGaash commented May 9, 2024

We look quite terrible on search results and social network shares
image

Tasks

  • add meta tags for search engine
  • add meta tags for social networks - facebook
  • add meta tags for social networks - twitter
  • add meta tags for social networks - others (?)
  • research if we're good in terms of sitemap and robots.txt files
  • do we need canonical refs to help search engines ignore the query params?
@NoamGaash NoamGaash added enhancement New feature or request good first issue Good for newcomers usability frontend frontend developers issue labels May 9, 2024
@EtayZaslavsky
Copy link
Collaborator

Hi there!
This is Etay, I wrote you @NoamGaash few days ago on Maakaf group.
I forked the repo, and will start to work on it soon.

@NoamGaash
Copy link
Member Author

Thanks @peaceful-dreamer ! looking forward to see the results 🤩

@EtayZaslavsky
Copy link
Collaborator

please grant write permission so I can push the new branch and open a PR :)

@NoamGaash
Copy link
Member Author

@EtayZaslavsky Done! :)

EtayZaslavsky pushed a commit that referenced this issue May 20, 2024
@R894 R894 linked a pull request May 21, 2024 that will close this issue
@NoamGaash NoamGaash removed a link to a pull request May 21, 2024
@NoamGaash
Copy link
Member Author

#759 solved some of the issues, great job 👏

EtayZaslavsky added a commit that referenced this issue May 22, 2024
Co-authored-by: etay <etay@zaslavsky.com>
@EtayZaslavsky
Copy link
Collaborator

Checked for meta tags for other social networks. They all use OpenGraph (except for twitter), which are included.

@EtayZaslavsky
Copy link
Collaborator

EtayZaslavsky commented May 30, 2024

As far as I understand we need a sitemap to make life easier for crawlers find their way in our React app.

It can be manually generated, or automatically generated.
A dynamically generated sitemap will always stay up-to-date, but will add another step after the build.
@NoamGaash @R894 What are your opinions?

@NoamGaash
Copy link
Member Author

@EtayZaslavsky it should be dynamically generated. When someone contributes a new page, they shouldn't be concerned about sitemap maintenance.
Also, we can add canonical links to make sure crawlers won't consider query parameters as new pages

@NoamGaash
Copy link
Member Author

Also, we need to think about adding all the line profile pages to the sitemap, and create dynamic titles for each page. We can open other issues for this topics

@supervxn
Copy link
Collaborator

@EtayZaslavsky נעים להכיר :-)
שמחה לעבוד איתך בפרויקט.

@EtayZaslavsky
Copy link
Collaborator

Hi @supervxn !
Welcome aboard :)

Would you like to take that?

Also, we need to think about adding all the line profile pages to the sitemap, and create dynamic titles for each page. We can open other issues for this topics

@supervxn
Copy link
Collaborator

Would

I'm helping with task management. So ask @NoamGaash

@EtayZaslavsky
Copy link
Collaborator

אה מצויין!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend frontend developers issue good first issue Good for newcomers usability
Projects
None yet
Development

No branches or pull requests

3 participants