feat: add SEO tags (#745) #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
R894
approved these changes
May 21, 2024
There was a problem hiding this comment.
Looks good to me!
Below are some suggestions I think might help us
If we want to take it a step further its also possible to add schema.org tags
<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "Website",
"name": "דאטאבוס",
"url": "https://open-bus-map-search.hasadna.org.il/",
"description": "אתר דאטאבוס מציג נתונים על איכות קווי התחבורה הציבורית בארץ, מתוך מקורות מידע ממשלתיים.",
"sameAs": [
"https://www.facebook.com/hasadna.org.il/",
"https://x.com/hasadna"
]
}
</script>After running the site through an SEO checker it also suggested using header tags ( <h1> - <h6> ), maybe we an add that somewhere also
NoamGaash
approved these changes
May 21, 2024
| <title>דאטאבוס</title> | ||
| <meta name="title" content='דאטאבוס - נתוני ביצוע לתחב"צ הישראלי' /> | ||
| <meta name="description" | ||
| content="אתר דאטאבוס מציג נתונים על איכות קווי התחבורה הציבורית בארץ, מתוך מקורות מידע ממשלתיים, במטרה להביא תמונת מצב על תפקוד התחבורה הציבורית בארץ." /> |
There was a problem hiding this comment.
That's a weird version of the logo, but why not? I like it.
|
Great! |
|
Thank you! 🥳 @all-contributors please add @EtayZaslavsky for code |
|
I've put up a pull request to add @EtayZaslavsky! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added SEO tags to index.html. added an image version of the svg logo for social networks' SEO.
Please review @NoamGaash :)