Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add date/timestamp in /gtfs_rides/list #404

Closed
idshklein opened this issue Aug 15, 2022 · 3 comments
Closed

add date/timestamp in /gtfs_rides/list #404

idshklein opened this issue Aug 15, 2022 · 3 comments
Assignees

Comments

@idshklein
Copy link
Collaborator

hi,
yesterday i tried to join siri_ride and gtfs_route. the way of doing so, according to this chart, is by joining siri_ride to gtfs_ride and than to gtfs_route.
however, i tried to download data for specific dates. where sirie_ride and gtfs_route contain a parameter to control timestamps/dates, gtfs_ride does not. this is a bit confusing, because it requires the users to download unnecessary data that may or may not contaion the relevant rows in gtfs_ride.
I'm suggesting adding a date/timestamp field to gtfs_ride, so a singke record of the output will look like:
{
"id": 18006203,
"gtfs_route_id": 1198104,
"journey_ref": "1_31728",
"date":"14-08-2022"
}

@OriHoch
Copy link

OriHoch commented Aug 15, 2022

I assume you are referring to the stride API?

So the change you want is that the response of the stride api method for gtfs_ride list will include the related gtfs_route date?

if you want siri_ride data, wouldn't it be easier if the response for siri_ride list will contain the related gtfs_ride / gtfs_route data? that way you will only have to make 1 api call

@OriHoch OriHoch self-assigned this Aug 15, 2022
@idshklein
Copy link
Collaborator Author

yes, what you suggested is a better solution

OriHoch added a commit to hasadna/open-bus-stride-api that referenced this issue Aug 15, 2022
@OriHoch
Copy link

OriHoch commented Aug 15, 2022

done, siri_rides/list stride API method now returns related gtfs_ride and gtfs_route data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants