added blueprint to baseframe-assets #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jace
requested changes
Nov 13, 2019
baseframe/__init__.py
Outdated
| @@ -248,6 +248,12 @@ def init_app( | |||
| app.assets.register('css_all', css_all) | |||
| app.register_blueprint(self, static_subdomain=subdomain) | |||
|
|
|||
| try: | |||
| module = __import__('baseframe-assets') | |||
There was a problem hiding this comment.
Asset name should be a parameter to the function here. There's no need for __import__ otherwise.
|
Original ticket: #165. |
jace
requested changes
Nov 20, 2019
baseframe/__init__.py
Outdated
| @@ -248,6 +248,14 @@ def init_app( | |||
| app.assets.register('css_all', css_all) | |||
| app.register_blueprint(self, static_subdomain=subdomain) | |||
|
|
|||
| for module_name in app.config.get('PRIVATE_ASSETS', []): | |||
There was a problem hiding this comment.
Don't use config as it's a statutory requirement for the client app and not a configuration issue. Take it as a parameter named asset_modules instead.
baseframe/__init__.py
Outdated
| module.blueprint.init_app_assets(app, assets) | ||
| app.register_blueprint(module.blueprint) | ||
| except ImportError: | ||
| continue |
There was a problem hiding this comment.
Log an error here (app logger or Blueprint logger).
jace
requested changes
Nov 23, 2019
jace
requested changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.