Emoji validate #253
Merged
Emoji validate #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambibhas
reviewed
Jan 14, 2020
jace
reviewed
Jan 14, 2020
| @@ -319,6 +320,15 @@ def __call__(self, form, field): | |||
| return | |||
| else: | |||
| raise ValidationError(self.message) | |||
|
|
|||
| class IsEmoji(object): | |||
|
|
|||
| class IsEmoji(object): | ||
|
|
||
| def __init__(self, message=None): | ||
| self.message = message |
There was a problem hiding this comment.
Fallback to a default message as in the other validators.
| @@ -319,6 +320,15 @@ def __call__(self, form, field): | |||
| return | |||
| else: | |||
| raise ValidationError(self.message) | |||
|
|
|||
| class IsEmoji(object): | |||
There was a problem hiding this comment.
This validator was inserted between two validators that are related to each other. This one should have been before or after them. Move it.
|
This is also missing tests, so it reduces overall test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.