Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: -m 26200 = OpenEdge Progress Encode code style #2840

Closed
philsmd opened this issue Jun 19, 2021 · 3 comments
Closed

tests: -m 26200 = OpenEdge Progress Encode code style #2840

philsmd opened this issue Jun 19, 2021 · 3 comments

Comments

@philsmd
Copy link
Member

philsmd commented Jun 19, 2021

The file tools/test_modules/m26200.pm uses a little bit strange indentation and code style (if-else).

This is just a reminder that we should probably change this code to make it look like our other perl code (code style/formatting).

Anybody volunteer to make these small changes ? it's probably just a few lines of changes (if-else branches etc).

Thanks

@philsmd philsmd added the bug label Jun 19, 2021
@matrix
Copy link
Member

matrix commented Jun 20, 2021

Hi @philsmd, put a "bug" label on these things it seems exaggerated :)
The code seems to work, you should modify it directly without opening an issue right?
Please remove "bug" label here also on #2841
Thanks

@jsteube
Copy link
Member

jsteube commented Jun 20, 2021

I think the label was added automatically by the template selection

@philsmd
Copy link
Member Author

philsmd commented Jun 22, 2021

Yeah, that's totally correct. I didn't intend to add the bug label... I could only select either a feature request or a bug template.

of course this "issue" was always meant to be just a nice-to-fix or nice-to-change feature because the code looked a little bit different from our other perl unit test code (but also this wouldn't be a major problem, don't get me wrong).

I just opened a couple of issues that day (see github issues: https://github.com/hashcat/hashcat/issues?q=is%3Aissue+author%3Aphilsmd) and just wanted to "report" all the minor problems I've seen lately (all of them were NOT really critical, of course).

I've now added a minor fix with the commit above. Thanks

jsteube added a commit that referenced this issue Jun 25, 2021
fixes #2840: minor code style changes for OpenEdge tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants