Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add labels to metrics and discover servicemonitors in all namespaces #821

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Apr 9, 2024

Description

This pull request changes the following:

  • Add labels to metrics
  • Allow prometheus operator to discover service-monitors in other namespaces

Related Issues

  • Closes #

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy changed the title fix: allow prometheus operator to discover service-monitors in other namespaces fix: add labels to metrics Apr 9, 2024
@leninmehedy leninmehedy changed the title fix: add labels to metrics fix: add labels to metrics and discover servicemonitors in all namespaces Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Unit Test Results

  26 files    26 suites   53s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit c18e9de.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (dbffd87) to head (c18e9de).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #821   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon merged commit 7430a67 into main Apr 9, 2024
20 of 23 checks passed
@jeromy-cannon jeromy-cannon deleted the fix-telemetry-2 branch April 9, 2024 18:22
swirlds-automation added a commit that referenced this pull request Apr 9, 2024
## [0.24.3](v0.24.2...v0.24.3) (2024-04-09)

### Bug Fixes

* add labels to metrics and discover servicemonitors in all namespaces ([#821](#821)) ([7430a67](7430a67))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants