Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce verbosity of vmap log #877

Merged
merged 24 commits into from
Jun 14, 2024
Merged

fix: reduce verbosity of vmap log #877

merged 24 commits into from
Jun 14, 2024

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Jun 10, 2024

Description

This pull request changes the following:

  • turned of debug marker VIRTUAL_MERKLE_STATS
  • change PR check workflow, moving Checkout Code before Check changed files
  • fixed typo in detecting changed files
  • change startupProbe for netwok-node pod
  • change to java 21 and newer version of hedera app
  • ignore error caused by NMT due to removing symbolic link

Related Issues

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

github-actions bot commented Jun 10, 2024

Unit Test Results

  26 files    26 suites   57s ⏱️
109 tests 105 ✔️ 4 💤 0
110 runs  106 ✔️ 4 💤 0

Results for commit 08d6ebe.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (2552c32) to head (08d6ebe).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #877   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

JeffreyDallas and others added 10 commits June 11, 2024 09:52
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
save

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as draft June 12, 2024 17:49
@JeffreyDallas
Copy link
Contributor Author

JeffreyDallas commented Jun 12, 2024

make ci-test failed locally on macPro,
similarly, root-container of network-node-0 , phase is Runnng, but Ready is false, with following logs

│   Type     Reason     Age               From               Message                                                                                                                                                                │
│   ----     ------     ----              ----               -------                                                                                                                                                                │
│   Normal   Scheduled  110s              default-scheduler  Successfully assigned fst-jeffrey/network-node0-0 to fst-control-plane                                                                                                 │
│   Normal   Pulling    109s              kubelet            Pulling image "ghcr.io/hashgraph/full-stack-testing/ubi8-init-dind:0.27.2"                                                                                             │
│   Normal   Pulled     88s               kubelet            Successfully pulled image "ghcr.io/hashgraph/full-stack-testing/ubi8-init-dind:0.27.2" in 324.259917ms (21.338773926s including waiting)                               │
│   Normal   Created    88s               kubelet            Created container root-container                                                                                                                                       │
│   Normal   Started    88s               kubelet            Started container root-container                                                                                                                                       │
│   Normal   Pulling    88s               kubelet            Pulling image "gcr.io/hedera-registry/uploader-mirror:1.3.0"                                                                                                           │
│   Normal   Pulled     70s               kubelet            Successfully pulled image "gcr.io/hedera-registry/uploader-mirror:1.3.0" in 200.628834ms (17.358921966s including waiting)                                             │
│   Normal   Created    70s               kubelet            Created container record-stream-uploader                                                                                                                               │
│   Normal   Started    70s               kubelet            Started container record-stream-uploader                                                                                                                               │
│   Normal   Pulled     70s               kubelet            Container image "gcr.io/hedera-registry/uploader-mirror:1.3.0" already present on machine                                                                              │
│   Normal   Created    70s               kubelet            Created container event-stream-uploader                                                                                                                                │
│   Normal   Started    70s               kubelet            Started container event-stream-uploader                                                                                                                                │
│   Normal   Pulling    70s               kubelet            Pulling image "docker.io/otel/opentelemetry-collector-contrib:0.72.0"                                                                                                  │
│   Normal   Pulled     60s               kubelet            Successfully pulled image "docker.io/otel/opentelemetry-collector-contrib:0.72.0" in 456.188292ms (10.720810421s including waiting)                                    │
│   Normal   Created    60s               kubelet            Created container otel-collector                                                                                                                                       │
│   Normal   Started    60s               kubelet            Started container otel-collector                                                                                                                                       │
│   Warning  Unhealthy  9s (x5 over 49s)  kubelet            Startup probe failed: sh: line 1: jshell: command not found 

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas
Copy link
Contributor Author

JeffreyDallas commented Jun 12, 2024

Login into github runner, and run make-ci manually, got the same error
of network-node0-0 could be Ready

│   Normal   Created      2m59s                kubelet            Created container event-stream-uploader                                                                                                                           │
│   Normal   Started      2m59s                kubelet            Started container event-stream-uploader                                                                                                                           │
│   Normal   Pulling      2m59s                kubelet            Pulling image "docker.io/otel/opentelemetry-collector-contrib:0.72.0"                                                                                             │
│   Normal   Pulled       2m48s                kubelet            Successfully pulled image "docker.io/otel/opentelemetry-collector-contrib:0.72.0" in 397.778927ms (11.261098634s including waiting)                               │
│   Normal   Created      2m48s                kubelet            Created container otel-collector                                                                                                                                  │
│   Normal   Started      2m47s                kubelet            Started container otel-collector                                                                                                                                  │
│   Warning  Unhealthy    81s (x9 over 2m41s)  kubelet            Startup probe failed: sh: line 1: jshell: command not found     

Login shell of root container, no jshell or java sdk installed

@JeffreyDallas
Copy link
Contributor Author

If running make ci-test with direct-install.sh

pod has error

Warning  Unhealthy  2m53s (x2 over 3m3s)  kubelet            Startup probe failed: java.net.UnknownHostException: network-node0.fst-jeffrey.svc.cluster.local: Name or service not known   

but jshell or java/sdk indeed installed already

[root@network-node0-0 hgcapp]# which java
/opt/java/openjdk/bin/java
[root@network-node0-0 hgcapp]# which jshell
/opt/java/openjdk/bin/jshell

Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
@JeffreyDallas JeffreyDallas marked this pull request as ready for review June 13, 2024 22:05
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Signed-off-by: Jeffrey Tang <jeffrey@swirldslabs.com>
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jeromy-cannon jeromy-cannon changed the title fix: reduce verbosity of vamp log fix: reduce verbosity of vmap log Jun 14, 2024
@jeromy-cannon jeromy-cannon merged commit 28487f1 into main Jun 14, 2024
19 checks passed
@jeromy-cannon jeromy-cannon deleted the 00781-D-vmap-log branch June 14, 2024 10:33
swirlds-automation added a commit that referenced this pull request Jul 1, 2024
## [0.28.3](v0.28.2...v0.28.3) (2024-07-01)

### Bug Fixes

* reduce verbosity of vmap log ([#877](#877)) ([28487f1](28487f1))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.28.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts[Network]: the nodes swirlds-vmap.log is too verbose
3 participants