Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic CI/CD #4

Closed
sergmetelin opened this issue Oct 14, 2021 · 4 comments
Closed

Implement basic CI/CD #4

sergmetelin opened this issue Oct 14, 2021 · 4 comments
Assignees
Labels
community enhancement New feature or request

Comments

@sergmetelin
Copy link
Collaborator

sergmetelin commented Oct 14, 2021

Requirements
As a user of the Guardian, prior to publishing a Policy Workflow Execution Instance, I would like to validate requirements such as schemas, tokens, etc. If there is an issue, I will need to know what requirement the issue is related to and how to fix it.

Pre-requisite
Information Architecture Diagrams? BRD's? FSD's for this Enhancement / Feature?

Definition of Done
The CI should cover linting as well as unit tests at a minimum.

Acceptance Criteria:
The CI should cover linting as well as unit tests at a minimum.

@sergmetelin sergmetelin added the enhancement New feature or request label Oct 14, 2021
@sergmetelin
Copy link
Collaborator Author

I guess another config is to limit merges to the main branch and all changes by default to be merged in develop? (depending on your branching strategy)

@blockchain-biopharma
Copy link
Collaborator

This is another Duplicate of Issue 40. Closing with a Link:

https://app.zenhub.com/workspaces/guardian-618c27c08661c0001461263a/issues/hashgraph/guardian/40

@anvabr anvabr reopened this Nov 25, 2021
@anvabr anvabr changed the title Implement CI and add a badge to the README.md repo Implement basic CI/CD Nov 25, 2021
@anvabr
Copy link
Collaborator

anvabr commented Nov 25, 2021

Note: Reopened the issue and changed its focus on implementation of the CI (budges are covered in the #40).

Requirements

CI/CD is a common 'best practice' to organising software development. This ticket requires the implementation of Github Actions workflow to be triggered every time a commit to main has occurred.

DOD

The workflow described in the Acceptance Criteria section below is executed automatically triggered by the change in the main repo.

Acceptance Criteria

Github Actions workflow exists in the /.github/workflows/ci.yml containing the following logic which gets executed on every commit to MAIN:

  • Codebase is "linted", i.e. checked and formatted by the lint utility
  • Repo is tagged
  • Software artefacts are built and published (where appropriate)
  • Unit tests are executed and the results are recorded

@blockchain-biopharma
Copy link
Collaborator

@danielnorkin @sergmetelin This was just QA Tested and complete, moving to Close.

gitbook-com bot pushed a commit that referenced this issue Mar 9, 2022
simvalery pushed a commit that referenced this issue Apr 10, 2024
Update and rename .txt to README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants