Create hip-362-token-freeze-amount.md #395
Conversation
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Update the Rationale and User story as per discussion with the original author.
|
@ToMaciANura updated the story and rationale per our Discord exchange. |
|
Could you check that the commits are signed off (failing DCO) DCO sign offs |
| @@ -0,0 +1,44 @@ | |||
| **hip: TBD </br> | |||
There was a problem hiding this comment.
| **hip: TBD </br> | |
| --- | |
| hip: 395 |
| title: Integrate '.setTokenAmount()' custom function for 'TokenFreezeTransaction()' </br> | ||
| author: Tomachi Anura [shibartoken@protonmail.com](mailto:shibartoken@protonmail.com)</br> | ||
| type: Standards Track</br> | ||
| category: Service</br> | ||
| needs-council-approval: Yes</br> | ||
| status: Draft</br> | ||
| last-call-date-time:</br> | ||
| created: 22.02.13</br> | ||
| discussions-to:**</br> |
There was a problem hiding this comment.
| title: Integrate '.setTokenAmount()' custom function for 'TokenFreezeTransaction()' </br> | |
| author: Tomachi Anura [shibartoken@protonmail.com](mailto:shibartoken@protonmail.com)</br> | |
| type: Standards Track</br> | |
| category: Service</br> | |
| needs-council-approval: Yes</br> | |
| status: Draft</br> | |
| last-call-date-time:</br> | |
| created: 22.02.13</br> | |
| discussions-to:**</br> | |
| title: Integrate `.setTokenAmount()` custom function for `TokenFreezeTransaction()` | |
| author: Tomachi Anura [shibartoken@protonmail.com](mailto:shibartoken@protonmail.com) | |
| type: Standards Track | |
| category: Service | |
| needs-council-approval: Yes | |
| status: Draft | |
| last-call-date-time: | |
| created: 22.02.13 | |
| discussions-to:** | |
| --- |
There was a problem hiding this comment.
Create a discussions for this and add the link to it in line 10
Update the Rationale and User story as per discussion with the original author. Signed-off-by: tomacianura <shibartoken@gmail.com>
Signed-off-by: tomacianura <shibartoken@gmail.com>
There was a problem hiding this comment.
It looks like you have elaborated some things here and it looks good, but the formatting is still off and the header is missing things like a discussion link etc. We also dont need these </br> tags. Refer to hip-1 to help with how to format a hip properly
Lastly, we are still failing the DCO check. Once we resolve this stuff I'll give my approval. Thanks for your attention here.
not sure what you guys are asking for, i can see all the commits have been properly signed: can you please be more precise with your request?
|
Sure. If you check out this link you'll find there are 3 commits that are not properly signed off DCO sign-off failures Also, the formatting is not right. If you go to this link and see and compare it to hip-1 (our template hip) you will see the formatting is not in alignment with this template hip. |
|
Reviewer update: Considering the cost of storage overheads wrt to our current architecture, freezing a set amount of tokens per account is not a priority at this time as it can be achieved using smart contracts. Thanks |
|
Sorry, but I just don’t get it. |
|
Implementing this functionality for our platform, to my understanding I'd have to build it with a SC and would then need to make sure that code is correct / solidity, and would not be able to achieve this through native Hedera. If we break away from building something better and start requiring Hedera devs to learn solidity / learn ETH languages to perform a functionality, I don't see how that pushes the Hedera Network forward or helps developers that are committed to the Hedera Network. |
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist