Hedera Schedule Service System Contract #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
lukelee-sl
reviewed
Jun 20, 2023
|
|
||
| Since smart contracts executions do not utilize the Hedera signature map they are unable to carry along the authorizations that the Hedera ledger uses to confirm an accounts participation and acknowledgment in a transaction. | ||
|
|
||
| To address this Smart Contracts could utilize the Hedera Schedule Service by submitting a scheduled transaction to which accounts can sign / authorize as an acceptance of the desired transaction. This flow provides as easy route for asynchronous coordination of transaction approval. |
There was a problem hiding this comment.
Suggested change
| To address this Smart Contracts could utilize the Hedera Schedule Service by submitting a scheduled transaction to which accounts can sign / authorize as an acceptance of the desired transaction. This flow provides as easy route for asynchronous coordination of transaction approval. | |
| To address this, Smart Contracts could utilize the Hedera Schedule Service by submitting a scheduled transaction which accounts can subsequently sign / authorize to indicate acceptance of the desired transaction. This flow provides an easy route for asynchronous coordination of transaction approval. |
lukelee-sl
reviewed
Jun 20, 2023
|
|
||
| In many decentralized scenarios a contract may issue a transaction that would require participation by multiple entities. | ||
|
|
||
| However, under the Hedera Smart Contract Service (HSCS) Security Model v2 it is not possible to authorize a contract in advance to modify an accounts property or cause a debit to their balance without their authorization. This essentially means multi party operations made challenging if not infeasible on smart contracts. |
There was a problem hiding this comment.
Suggested change
| However, under the Hedera Smart Contract Service (HSCS) Security Model v2 it is not possible to authorize a contract in advance to modify an accounts property or cause a debit to their balance without their authorization. This essentially means multi party operations made challenging if not infeasible on smart contracts. | |
| This essentially means multi party operations are made challenging if not infeasible when using smart contracts. |
lukelee-sl
reviewed
Jun 20, 2023
|
|
||
| ## Rationale | ||
|
|
||
| By providing a secure mechanism to acquire asynchronous authorization from multiple accounts, smart contracts can continue to be used for more decentralized operations whiles still maintaining the integrity of account sovereignty by allowing accounts to approve confirm their participation in a transaction. |
There was a problem hiding this comment.
Suggested change
| By providing a secure mechanism to acquire asynchronous authorization from multiple accounts, smart contracts can continue to be used for more decentralized operations whiles still maintaining the integrity of account sovereignty by allowing accounts to approve confirm their participation in a transaction. | |
| By providing a secure mechanism to acquire asynchronous authorization from multiple accounts, smart contracts can continue to be used for more decentralized operations while still maintaining the integrity of account sovereignty by allowing accounts to approve and confirm their participation in a transaction. |
|
|
||
| ## Specification | ||
|
|
||
| The ledger HSCS will utilize the existing scheduled transaction service supported on the ledger within the system contract logic. |
There was a problem hiding this comment.
Suggested change
| The ledger HSCS will utilize the existing scheduled transaction service supported on the ledger within the system contract logic. | |
| HSCS will utilize the existing scheduled transaction service supported on the ledger within the system contract logic. |
|
|
||
| Since `signSchedule(address scheduleAddress) returns (int64 responseCode)` relies on an implicit signature it will only callable by EOA’s via the IHRC facade. | ||
| In this case the signature will be the inner ECDSA signature found in the RLP encoded `EthereumTransaction`. | ||
| For `Contract` and `ContractCreate` any applicable signature found in the signature map will be utilized as in `ScheduleSign`. |
There was a problem hiding this comment.
I'm not sure if I understand what this sentence means? What is ScheduleSign referencing?
There was a problem hiding this comment.
This is referencing the ScheduleSign transaction. Basically, just as the network pulls signatures for ScheduleSign it should also pull signatures from the map for ContractCall and ContractCreate if the execution logic applies to scheduled transactions
| ## Security Implications | ||
|
|
||
| Existing security consideration such as throttles will remain applicable. | ||
| Additional considerations may include |
There was a problem hiding this comment.
The rest of the section are the completion of the section. Let me update it to be more explicit
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
mgarbs
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This proposal addresses the feature gap of a smart contracts ability to issue scheduled transactions via the HAPI scheduled transactions.
Since smart contracts executions do not utilize the Hedera signature map they are unable to carry along the authorizations that the Hedera ledger uses to confirm an accounts participation and acknowledgment in a transaction.
To address this Smart Contracts could utilize the Hedera Schedule Service by submitting a scheduled transaction to which accounts can sign / authorize as an acceptance of the desired transaction. This flow provides as easy route for asynchronous coordination of transaction approval.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist