2149 add websocket tests for newheads #2169
Conversation
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
…tance to false. Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
…tation. Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
requested review from
AlfredoG87,
georgi-l95,
Ivo-Yankov,
a team,
Nana-EC and
lukelee-sl
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
| expect(response.params).to.have.property('subscription'); | ||
| } | ||
|
|
||
| if (responseCounter > 1) { |
There was a problem hiding this comment.
To be clear this will mean the test will only ever confirm 2 responses.
The 1st to get the subscription ID and the 2nd to get the 1st block. You'll never confirm more than 1 blocks details.
You should definitely be testing for 0,1 and n numbers of blocks cases.
There was a problem hiding this comment.
Yes, it's a subscription so I need to limit the number of responses I test and focus on the content of those responses.
|
Addressed in PR #2225 |
|
Added websocket test for block content, fixed the JSON response and the design document.
Related issue(s): #2117
Fixes #