fix: resolved evm addresses for from and to addresses in returned transactions
#2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
applied to eth_getBlockByNumber, eth_getBlockByHash Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…ethod Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
… method Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Nana-EC
reviewed
Mar 11, 2024
…sactionByBlockNumberAndIndex into a shared method Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…s values if null from Mirror Node Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
quiet-node
force-pushed
the
2128-incompatible-toaddress-in-json-rpc-response
branch
from
d8b2159
to
9a3e1ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 13 13
Lines 644 644
Branches 118 118
=======================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
Nana-EC
reviewed
Mar 12, 2024
| const fromAccountInfo = await mirrorNode.get(`/accounts/${tx.from}`); | ||
| const toAccountInfo = await mirrorNode.get(`/accounts/${tx.to}`); | ||
|
|
||
| if (fromAccountInfo) { |
There was a problem hiding this comment.
Can simplify
Suggested change
| if (fromAccountInfo) { | |
| if (fromAccountInfo?.evmAddress) { | |
| tx.from = fromAccountInfo.evm_address; |
There was a problem hiding this comment.
Pushed in the fix
| @@ -61,6 +61,21 @@ describe('@api-batch-1 RPC Server Acceptance Tests', function () { | |||
| const ONE_TINYBAR = Utils.add0xPrefix(Utils.toHex(Constants.TINYBAR_TO_WEIBAR_COEF)); | |||
| const sendRawTransaction = relay.sendRawTransaction; | |||
|
|
|||
| const resolveEvmAddress = async (tx: any) => { | |||
There was a problem hiding this comment.
Suggested change
| const resolveEvmAddress = async (tx: any) => { | |
| const resolveAccountEvmAddresses = async (tx: any) => { |
or
Suggested change
| const resolveEvmAddress = async (tx: any) => { | |
| const extractAccountEvmAddresses = async (tx: any) => { |
There was a problem hiding this comment.
Pushed in the fix
| @@ -61,6 +61,21 @@ describe('@api-batch-1 RPC Server Acceptance Tests', function () { | |||
| const ONE_TINYBAR = Utils.add0xPrefix(Utils.toHex(Constants.TINYBAR_TO_WEIBAR_COEF)); | |||
| const sendRawTransaction = relay.sendRawTransaction; | |||
|
|
|||
| const resolveEvmAddress = async (tx: any) => { | |||
There was a problem hiding this comment.
Add comments on the function to explain behaviour and function signature
There was a problem hiding this comment.
Pushed in the fix
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
|
Nana-EC
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
resolved long zero addresses to EVM addresses for the following RPC endpoints:
eth_getTransactionByBlockHashAndIndexeth_getTransactionByBlockNumberAndIndexeth_getBlockByHasheth_getBlockByNumberfixed unit tests where necessary
Related issue(s):
Fixes #2128
Notes for reviewer:
Checklist