fix: added support for legacy pre EIP 155 transactions with no chainI… #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D (chainId=0x0) (#2228) * feat: added support for legacy unprotected ETX pre EIP-155 (chainID=0x0) Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: added new UT for precheck.chainId() with a case that has chainID=0x0 Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * test: fixed UT to allow support for pre EIP155 txs Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> * feat: added isLegacyUnprotectedEtx() method Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com> --------- Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
|
AlfredoG87
requested review from
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.44 #2240 +/- ##
=============================================
Coverage 75.15% 75.15%
=============================================
Files 13 13
Lines 644 644
Branches 118 118
=============================================
Hits 484 484
Misses 115 115
Partials 45 45 ☔ View full report in Codecov by Sentry. |
ebadiere
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry-Pick PR #2228 onto release
0.44Related issue(s):
Fixes #
Notes for reviewer:
Checklist