Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect "JavaScript heap out of memory" errors and fail job. #2263

Closed
wants to merge 9 commits into from

Conversation

ebadiere
Copy link
Collaborator

Modified job to detect "JavaScript heap out of memory" errors.

Related issue(s): #2262

Fixes #

Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere added the bug Something isn't working label Mar 28, 2024
@ebadiere ebadiere added this to the 0.46.0 milestone Mar 28, 2024
@ebadiere ebadiere self-assigned this Mar 28, 2024
@ebadiere ebadiere requested a review from a team as a code owner March 28, 2024 22:04
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.15%. Comparing base (9bcd305) to head (6710f62).
Report is 1 commits behind head on main.

❗ Current head 6710f62 differs from pull request most recent head 9ab4317. Consider uploading reports for the commit 9ab4317 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2263   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files          13       13           
  Lines         644      644           
  Branches      118      118           
=======================================
  Hits          484      484           
  Misses        115      115           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 28, 2024

Acceptance Tests

  12 files  185 suites   15m 24s ⏱️
577 tests 573 ✔️ 4 💤 0
612 runs  608 ✔️ 4 💤 0

Results for commit 78ca862.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Mar 29, 2024
AlfredoG87
AlfredoG87 previously approved these changes Apr 5, 2024
Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to wait until we actually fix the issue to merge it, but otherwise LGTM

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere dismissed stale reviews from AlfredoG87 and Nana-EC via a5a108b April 19, 2024 21:35
Signed-off-by: ebadiere <ebadiere@gmail.com>
@konstantinabl
Copy link
Collaborator

Addressed here #2305
So we can maybe close this PR : )

…om/hashgraph/hedera-json-rpc-relay into 2262-JavaScript-Heap-out-of-memory

Signed-off-by: ebadiere <ebadiere@gmail.com>
@AlfredoG87 AlfredoG87 modified the milestones: 0.46.0, 0.47.0 Apr 23, 2024
Signed-off-by: ebadiere <ebadiere@gmail.com>
…om/hashgraph/hedera-json-rpc-relay into 2262-JavaScript-Heap-out-of-memory

Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: ebadiere <ebadiere@gmail.com>
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ebadiere
Copy link
Collaborator Author

Replaced by #2395

@ebadiere ebadiere closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants