Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cherry pick #2377 on 0.46 release #2385

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

AlfredoG87
Copy link
Collaborator

Description:

Cherry Pick #2377 on release/0.46 branch in preparations for 0.46.1 release

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* fix: wrong gas estimation due to invalid tx object

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

optimization

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

chore: fix typo

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

test: add unit test

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

fix logic

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

delete input if not used

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* add simple fix

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* remove unused import

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* revert changes

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* fix acceptance tests

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

* add unit tests

Signed-off-by: georgi-l95 <glazarov95@gmail.com>

---------

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Copy link

sonarcloud bot commented Apr 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlfredoG87 AlfredoG87 marked this pull request as ready for review April 22, 2024 21:53
@AlfredoG87 AlfredoG87 changed the title Cherry pick #2377 on 0.46 release chore: Cherry pick #2377 on 0.46 release Apr 22, 2024
Copy link

Tests

    1 files    35 suites   3s ⏱️
194 tests 193 ✔️ 1 💤 0
197 runs  196 ✔️ 1 💤 0

Results for commit e55172f.

Copy link

github-actions bot commented Apr 22, 2024

Acceptance Tests

     15 files     311 suites   18m 30s ⏱️
   587 tests    572 ✔️ 4 💤 11
1 113 runs  1 095 ✔️ 4 💤 14

Results for commit e55172f.

♻️ This comment has been updated with latest results.

@AlfredoG87 AlfredoG87 merged commit 76c45e1 into release/0.46 Apr 22, 2024
28 of 29 checks passed
@AlfredoG87 AlfredoG87 deleted the cherry-pick-2377-on-0-46 branch April 22, 2024 22:46
@AlfredoG87 AlfredoG87 self-assigned this Apr 23, 2024
@AlfredoG87 AlfredoG87 added the process Build, test and deployment-process related tasks label Apr 23, 2024
@AlfredoG87 AlfredoG87 modified the milestone: 0.46.1 Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants