Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display metadata content and image when available for NFT #1013

Merged
merged 13 commits into from
Jun 25, 2024
Merged

feat: display metadata content and image when available for NFT #1013

merged 13 commits into from
Jun 25, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented May 16, 2024

Description:

Modify NftDetails view to:

  • display image associated to token when available
  • make certain metadata attributes prominent when available (name, description, creator)
  • display the details of the metadata content when available

Related issue(s):

Fixes #1004

Notes for reviewer:

Screenshot 2024-05-16 at 16 46 16

(also on staging server)

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@svienot svienot requested a review from ericleponner May 16, 2024 14:50
@svienot svienot force-pushed the 1004-token-metadata-content branch from 516c055 to eba509d Compare May 17, 2024 08:14
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.91% 41349 / 49274
🔵 Statements 83.91% 41349 / 49274
🔵 Functions 63.22% 925 / 1463
🔵 Branches 84.1% 4380 / 5208
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/MediaContent.vue 94.02% 96.42% 27.27% 94.02% 136-137, 156-159, 163-165, 176-179, 192-193
src/components/account/CollectionTable.vue 77.85% 100% 0% 77.85% 106-138
src/components/token/MetadataSection.vue 98.41% 100% 50% 98.41% 99-100, 115-116
src/components/token/NftAttribute.vue 100% 87.5% 100% 100%
src/components/token/NftCell.vue 99.23% 96% 100% 99.23% 106
src/components/token/NftHolderTable.vue 91.35% 100% 33.33% 91.35% 125-138
src/components/token/TokenMetadataAnalyzer.ts 82.15% 80% 100% 82.15% 85-91, 109-113, 151-155, 163-183, 250-251, 262-263, 279-280, 291-297, 312-313, 315-318, 332-333, 335-338
src/components/values/BlobValue.vue 91.15% 75% 100% 91.15% 46-49, 55-57, 136-137, 146-147, 155-159, 175-176, 194-195
src/pages/NftDetails.vue 94.38% 84% 33.33% 94.38% 249, 277, 280-281, 286, 325-331, 359-367
src/pages/TokenDetails.vue 99.04% 96.89% 66.66% 99.04% 432, 445-446, 501-502
Generated in workflow #1041

@svienot svienot force-pushed the 1004-token-metadata-content branch 6 times, most recently from 45eaf80 to 5bbf395 Compare May 27, 2024 18:33
@svienot svienot force-pushed the 1004-token-metadata-content branch from 5bbf395 to 951764a Compare May 28, 2024 18:34
@svienot svienot force-pushed the 1004-token-metadata-content branch 5 times, most recently from f418410 to 669a933 Compare June 12, 2024 11:09
@svienot svienot self-assigned this Jun 12, 2024
@svienot svienot force-pushed the 1004-token-metadata-content branch from ffe170d to a50e2b4 Compare June 12, 2024 14:07
@svienot svienot marked this pull request as ready for review June 12, 2024 14:10
ericleponner
ericleponner previously approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@svienot
Add TokenMetadataAnalyzer (for further use).
1a487dd 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add NftAttribute (for further use).
19c89c5 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add MetadataSection (for further use).
7a1276b 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Leverage NFT metadata and image in NftDetails view.
2188a30 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add NftCell (for further use).
9e3109f 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Leverage NFT metadata and image in CollectionTable.
58863a0 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Leverage NFT metadata and image in NftHolderTable.
6e65d08 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add MetadataSection to TokenDetails view.
e8089cf 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Make spinner smaller when MediaContent is under 100px.
1ae1fc6 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Import IPFS_GATEWAY_PREFIX from Mocks.
6552b99 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Adjust TokenNavigation e2e test to NftHolderTable changes.
b5c74aa 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Force UTC in NftAttribute unit test.
c5f71f3 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Augment threshold for boxing the BlobValue text.
867bc55 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot force-pushed the 1004-token-metadata-content branch from a50e2b4 to 867bc55 Compare June 25, 2024 16:41
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
16.1% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@svienot svienot merged commit 58332c2 into main Jun 25, 2024
7 of 8 checks passed
@svienot svienot deleted the 1004-token-metadata-content branch June 25, 2024 17:16
@svienot svienot mentioned this pull request Jun 25, 2024
Merged
ericleponner pushed a commit that referenced this pull request Jun 25, 2024
@svienot
chore: follow up to PR #1013 (#1149)
cf522f9 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees

@svienot svienot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display metadata content and associated image when available for NFT
2 participants
@svienot @ericleponner