Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search Bar now uses api/v1/topics new REST call when previewnet is selected #1136

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below alter SearchRequest class so that it uses api/v1/topics/{topicId} when previewnet.
For mainnet and testnet, behavior is unchanged (use of api/v1/topics/{topicId}/messages).
Changes also include unit tests adaptation to this new logic.

Related issue(s):

Fixes #1109

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…wnet.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…} is used when network is previewnet.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Copy link

sonarcloud bot commented Jun 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
48.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 83.05% 40136 / 48324
🔵 Statements 83.05% 40136 / 48324
🔵 Functions 62.76% 902 / 1437
🔵 Branches 84.06% 4190 / 4984
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/SearchBar.vue 52.22% 50% 14.28% 52.22% 28-40, 47, 59-60, 104-105, 107-120, 123-206, 209, 219
src/utils/SearchRequest.ts 87.72% 80.26% 92.3% 87.72% 128-133, 145-146, 167-170, 199-201, 207-208, 228-229, 316-319, 350-353, 355-362, 367-368, 373-382
Generated in workflow #1025

Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@ericleponner ericleponner merged commit e42e39e into main Jun 19, 2024
7 of 8 checks passed
@ericleponner ericleponner deleted the 001109_seearch_by_topic_id branch June 19, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HIP-874 search by topic ID
2 participants