Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboards and alerts #1827

Merged
merged 1 commit into from Apr 8, 2021
Merged

Fix dashboards and alerts #1827

merged 1 commit into from Apr 8, 2021

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Apr 7, 2021

Detailed description:

  • Add a TimescaleDB PodMonitor so Prometheus can scrape it
  • Add a log level rate graph to REST API dashboard
  • Bump to actions/setup-java@v2
  • Change CI Java distribution from Zulu to AdoptOpenJDK since the latter is more FOSS friendly
  • Fix Loki based graphs and alerts broken due to default label configs changing upstream
  • Remove unnecessary -Djib.to.tags

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P2 ops Tasks relating to network operations labels Apr 7, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.32.0 milestone Apr 7, 2021
@steven-sheehy steven-sheehy requested a review from a team April 7, 2021 21:41
@steven-sheehy steven-sheehy self-assigned this Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #1827 (bb971c9) into master (8125fd6) will not change coverage.
The diff coverage is n/a.

❗ Current head bb971c9 differs from pull request most recent head eb6342e. Consider uploading reports for the commit eb6342e to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1827   +/-   ##
=========================================
  Coverage     87.37%   87.37%           
  Complexity     1743     1743           
=========================================
  Files           315      315           
  Lines          7691     7691           
  Branches        735      735           
=========================================
  Hits           6720     6720           
  Misses          744      744           
  Partials        227      227           
Impacted Files Coverage Δ Complexity Δ
transactions.js 98.11% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e4fa1...eb6342e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 7, 2021

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 80ffb6e into master Apr 8, 2021
@steven-sheehy steven-sheehy deleted the fix-dashboards branch April 8, 2021 16:32
ijungmann pushed a commit that referenced this pull request May 18, 2021
- Add a TimescaleDB `PodMonitor` so Prometheus can scrape it
- Add a log level rate graph to REST API dashboard
- Bump to `actions/setup-java@v2`
- Change CI Java distribution from Zulu to AdoptOpenJDK since the latter is more FOSS friendly
- Fix Loki based graphs and alerts broken due to default label configs changing upstream
- Remove unnecessary `-Djib.to.tags`

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working ops Tasks relating to network operations P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants