Updated scheduled tests #1846
Merged
Updated scheduled tests #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
…scenario Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
Nana-EC
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
============================================
- Coverage 87.37% 87.00% -0.38%
- Complexity 1743 1745 +2
============================================
Files 315 315
Lines 7691 7731 +40
Branches 735 738 +3
============================================
+ Hits 6720 6726 +6
- Misses 744 778 +34
Partials 227 227
Continue to review full report at Codecov.
|
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
xin-hedera
requested changes
Apr 13, 2021
...n/java/com/hedera/datagenerator/sdk/supplier/schedule/ScheduleCreateTransactionSupplier.java
Outdated
Show resolved
Hide resolved
...r-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/AbstractNetworkClient.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/ScheduleClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
|
SonarCloud Quality Gate failed. |
ijungmann
suggested changes
Apr 14, 2021
ijungmann
approved these changes
Apr 14, 2021
ijungmann
pushed a commit
that referenced
this pull request
May 18, 2021
Scheduled transactions were updated in accordance with the [redesign](https://github.com/hashgraph/hedera-services/blob/master/docs/scheduled-transactions/revised-spec.md). This resulted in a new protobuf and a new sdk version - Pull in sdk version `2.0.5-beta.7` which uses new protobuf into data-generator, monitor and test modules - Update `ScheduleClient` to no longer sign inner transaction but outer - Update `ScheduleScenario` to handle verifications, including additional signatures that aren't required - Update monitor Schedule transaction logic - Update monitor publish logic to handle transactions with nodes set - Add HCS message publish in background to reduce likelihood of stale data Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Scheduled transactions were updated in accordance with the redesign. This resulted in a new protobuf and a new sdk version
2.0.5-beta.7which uses new protobuf into data-generator, monitor and test modulesScheduleClientto no longer sign inner transaction but outerScheduleScenarioto handle verifications, including additional signatures that aren't requiredWhich issue(s) this PR fixes:
Fixes #1822
Fixes #1821
Special notes for your reviewer:
Checklist