Add cloud storage metrics #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
============================================
- Coverage 87.37% 87.07% -0.31%
- Complexity 1743 1748 +5
============================================
Files 315 315
Lines 7691 7736 +45
Branches 735 738 +3
============================================
+ Hits 6720 6736 +16
- Misses 744 773 +29
Partials 227 227
Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
|
SonarCloud Quality Gate failed. |
Nana-EC
requested changes
Apr 14, 2021
hedera-mirror-importer/src/main/java/com/hedera/mirror/importer/downloader/PendingDownload.java
Show resolved
Hide resolved
ijungmann
pushed a commit
that referenced
this pull request
May 18, 2021
- Add `hedera.mirror.importer.cloud.latency` metric to compare consensus time against cloud storage creation time - Add `hedera.mirror.download.latency` metric to all stream types - Add `hedera.mirror.stream.close.latency` metric to all stream types - Fix event file not persisting due to missing required consensus end field - Fix cloud storage response size and time metrics not counting `_sig.gz` files as signature files Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
hedera.mirror.importer.cloud.latencymetric to compare consensus time against cloud storage creation timehedera.mirror.download.latencymetric to all stream typeshedera.mirror.stream.close.latencymetric to all stream types_sig.gzfiles as signature filesWhich issue(s) this PR fixes:
Special notes for your reviewer:
Checklist