Support contract initcode #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
added
P1
parser
xin-hedera
commented
Apr 21, 2022
Comment on lines
-230
to
-233
| if (contractCreateResult.hasEvmAddress()) { | ||
| contract.setEvmAddress(DomainUtils.toBytes(contractCreateResult.getEvmAddress().getValue())); | ||
| } | ||
|
|
There was a problem hiding this comment.
there won't be an evm address since the method is only used to process contract entities in CreatedContractIDs in protobuf pre services 0.23
steven-sheehy
previously approved these changes
Apr 21, 2022
hedera-mirror-common/src/main/java/com/hedera/mirror/common/domain/contract/Contract.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Li <xin.li@hedera.com>
|
Kudos, SonarCloud Quality Gate passed!
|
steven-sheehy
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support of contract initcode.
Related issue(s):
Fixes #3607
Fixes #3622
Notes for reviewer:
Checklist