Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importer jar name in release artifact #473

Merged
merged 1 commit into from Dec 31, 2019
Merged

Fix importer jar name in release artifact #473

merged 1 commit into from Dec 31, 2019

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Fix jar named as jarname=hedera-mirror-importer-0.5.0-beta2.jar inside tgz
  • Simplify script to just use $NAME (having a version with or without v doesn't matter to deploy.sh)
  • Add set -e to fail fast when any commands returns non-zero
  • Bump version to 0.5.0-beta3

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P1 process Build, test and deployment-process related tasks labels Dec 31, 2019
@steven-sheehy steven-sheehy added this to the Mirror 0.5.0 milestone Dec 31, 2019
@codecov
Copy link

codecov bot commented Dec 31, 2019

Codecov Report

Merging #473 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #473      +/-   ##
============================================
- Coverage     60.79%   60.75%   -0.04%     
+ Complexity      101      100       -1     
============================================
  Files            78       78              
  Lines          2686     2686              
  Branches        340      340              
============================================
- Hits           1633     1632       -1     
  Misses          899      899              
- Partials        154      155       +1
Impacted Files Coverage Δ Complexity Δ
...era/mirror/grpc/listener/PollingTopicListener.java 93.75% <0%> (-3.13%) 11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2390d58...1bc9cec. Read the comment docs.

@steven-sheehy steven-sheehy self-assigned this Dec 31, 2019
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 61f862c into master Dec 31, 2019
@steven-sheehy steven-sheehy deleted the beta3 branch December 31, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P1 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants