Remove entityStakeQuery from accounts REST API #7391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7391 +/- ##
============================================
+ Coverage 92.46% 92.57% +0.11%
+ Complexity 6870 6760 -110
============================================
Files 865 848 -17
Lines 28608 28334 -274
Branches 3349 3325 -24
============================================
- Hits 26451 26231 -220
+ Misses 1386 1337 -49
+ Partials 771 766 -5 ☔ View full report in Codecov by Sentry. |
steven-sheehy
approved these changes
Dec 15, 2023
edwin-greene
deleted the
7237-db-query-in-rest-api-accountsid-includes-unnecessary-entity-stake-condition
branch
bilyana-gospodinova
pushed a commit
that referenced
this pull request
Jan 19, 2024
Remove entityStakeQuery Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
bilyana-gospodinova
pushed a commit
that referenced
this pull request
Jan 24, 2024
Remove entityStakeQuery Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove the unnecessary entityStakeQuery from the accounts balances REST api queries.
Related issue(s):
Fixes #7237
Notes for reviewer:
Checklist