Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when running RecordFileParserPerformanceTest #8016

Merged

Conversation

xin-hedera
Copy link
Collaborator

Description:

  • Add missing system properties to performanceTest gradle task

Related issue(s):

Fixes #8015

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Xin Li <xin@swirldslabs.com>
@xin-hedera xin-hedera added this to the 0.103.0 milestone Apr 3, 2024
@xin-hedera xin-hedera self-assigned this Apr 3, 2024
@xin-hedera xin-hedera linked an issue Apr 3, 2024 that may be closed by this pull request
@xin-hedera xin-hedera added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Apr 3, 2024
@xin-hedera xin-hedera requested a review from a team April 3, 2024 14:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (cb5b6ef) to head (69caf36).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8016      +/-   ##
============================================
+ Coverage     92.33%   92.42%   +0.09%     
+ Complexity     7180     4767    -2413     
============================================
  Files           893      661     -232     
  Lines         29095    21038    -8057     
  Branches       3506     2619     -887     
============================================
- Hits          26865    19445    -7420     
+ Misses         1446     1051     -395     
+ Partials        784      542     -242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

steven-sheehy
steven-sheehy previously approved these changes Apr 3, 2024
Signed-off-by: Xin Li <xin@swirldslabs.com>
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link

sonarcloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@xin-hedera xin-hedera merged commit f40a290 into main Apr 3, 2024
33 checks passed
@xin-hedera xin-hedera deleted the 8015-recordfileparserperformancetest-fails-to-start branch April 3, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordFileParserPerformanceTest fails to start
4 participants