Increase max header size #8069
Merged
Increase max header size #8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8069 +/- ##
=========================================
Coverage 92.32% 92.33%
- Complexity 7181 7182 +1
=========================================
Files 893 893
Lines 29100 29100
Branches 3508 3508
=========================================
+ Hits 26868 26870 +2
+ Misses 1448 1447 -1
+ Partials 784 783 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
1KBto2KB/web3routingRelated issue(s):
Fixes #8068
Notes for reviewer:
After switching from Reactor Netty to Tomcat, suddenly our 1KB max header restriction apparently started taking effect and causing 400 errors for browser-based clients with really verbose headers added implicitly by the browser.
Checklist