Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equivalence acceptance test regression #8107

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Fix equivalence acceptance test regression caused by different 400 error message after recent refactor

Related issue(s):

Fixes #8102

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc regression labels Apr 15, 2024
@steven-sheehy steven-sheehy added this to the 0.103.0 milestone Apr 15, 2024
@steven-sheehy steven-sheehy requested a review from a team April 15, 2024 16:06
@steven-sheehy steven-sheehy self-assigned this Apr 15, 2024
Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.23%. Comparing base (1cebbfc) to head (32bd065).
Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #8107       +/-   ##
=============================================
+ Coverage     77.73%   92.23%   +14.49%     
- Complexity      109     7281     +7172     
=============================================
  Files            18      901      +883     
  Lines           274    29284    +29010     
  Branches         23     3572     +3549     
=============================================
+ Hits            213    27010    +26797     
- Misses           56     1452     +1396     
- Partials          5      822      +817     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit d12d35a into main Apr 15, 2024
25 of 26 checks passed
@steven-sheehy steven-sheehy deleted the 8102-fix-acceptance-400-errors branch April 15, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working regression test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance tests broken on integration
5 participants