Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf changes for HIP-206 #120

Merged
merged 2 commits into from Dec 1, 2021
Merged

Protobuf changes for HIP-206 #120

merged 2 commits into from Dec 1, 2021

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Nov 30, 2021 •
edited

Description:

  • Adds response codes REVERTED_SUCCESS and MAX_STORAGE_IN_PRICE_REGIME_HAS_BEEN_USED.
  • Supports child records via TransactionID#nonce and TransactionRecord#parent_consensus_timestamp.
  • Permits querying for child receipts and records by parent TransactionID.
  • Adds delegatable_contract_id key type.

Initial commit
fd13496 
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
SimiHunjan
SimiHunjan previously approved these changes Nov 30, 2021
View reviewed changes
This was referenced Nov 30, 2021
Closed
Closed
Closed
steven-sheehy
steven-sheehy previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit about a comment

services/basic_types.proto Outdated Show resolved Hide resolved
Define the TransactionID.nonce as an identifier for an internal trans…
f446af4 
…action

Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
@tinker-michaelj tinker-michaelj merged commit 47ef4c4 into develop Dec 1, 2021
@tinker-michaelj tinker-michaelj deleted the HIP-206/final-form branch December 1, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shemnon shemnon shemnon approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@SimiHunjan SimiHunjan SimiHunjan approved these changes

@janaakhterov janaakhterov Awaiting requested review from janaakhterov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tinker-michaelj @shemnon @steven-sheehy @SimiHunjan