-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precompile call data to ContractFunctionResults #163
Conversation
Add precompiled call data for parameters, gas, and amount to the ContractFunctionResults. These would be in the TransactionBody if it was a normal call but the body for precompiles is a different type, Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions.
Commenting rather than requesting changes so as not to block whiles i'm OOF
Please wait for 1 mirror node team member sign off before merging.
Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Add precompiled call data for parameters, gas, and amount to the
ContractFunctionResults. These would be in the TransactionBody
if it was a normal call but the body for precompiles is a
different type,
Signed-off-by: Danno Ferrin danno.ferrin@hedera.com
Related issue(s):
Fixes #157
Checklist