Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompile call data to ContractFunctionResults #163

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Mar 15, 2022

Description:

Add precompiled call data for parameters, gas, and amount to the
ContractFunctionResults. These would be in the TransactionBody
if it was a normal call but the body for precompiles is a
different type,

Signed-off-by: Danno Ferrin danno.ferrin@hedera.com

Related issue(s):

Fixes #157

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Add precompiled call data for parameters, gas, and amount to the
ContractFunctionResults. These would be in the TransactionBody
if it was a normal call but the body for precompiles is a
different type,

Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.
Commenting rather than requesting changes so as not to block whiles i'm OOF
Please wait for 1 mirror node team member sign off before merging.

services/contract_call_local.proto Outdated Show resolved Hide resolved
services/contract_call_local.proto Show resolved Hide resolved
services/contract_call_local.proto Show resolved Hide resolved
Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand ContractFunctionResult to include FunctionParameters, Amount and GasLimit
5 participants