Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-renew account support for files and accounts #236

Merged
merged 5 commits into from
Oct 28, 2022
Merged

Add auto-renew account support for files and accounts #236

merged 5 commits into from
Oct 28, 2022

Conversation

tinker-michaelj
Copy link
Contributor

Description:

  • Adds protobuf fields for setting, updating, and retrieving auto-renew accounts for accounts and files.

@tinker-michaelj
Add auto-renew account suppport for files and accounts
b5a9972 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners October 27, 2022 18:24
Neeharika-Sompalli
Neeharika-Sompalli previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Nana-EC
Nana-EC previously approved these changes Oct 27, 2022
View reviewed changes
xin-hedera
xin-hedera previously approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinker-michaelj
Remove _id suffix from auto_renew_account_id
c3c3200 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Drop one more _id
3fb2df0 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Drop one more _id
4914cfc 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj
Oops
12ff795 
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
steven-sheehy
steven-sheehy approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Neeharika-Sompalli
Neeharika-Sompalli approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tinker-michaelj tinker-michaelj merged commit daf26a0 into main Oct 28, 2022
@tinker-michaelj tinker-michaelj deleted the add-auto-renew-accounts branch October 28, 2022 16:37
This was referenced Nov 1, 2022
Open
Open
Open
Open
Open
This was referenced Nov 1, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@tinker-michaelj tinker-michaelj mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@xin-hedera xin-hedera xin-hedera approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@mhess-swl mhess-swl Awaiting requested review from mhess-swl mhess-swl is a code owner automatically assigned from hashgraph/hedera-services

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/mirror-node

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tinker-michaelj @steven-sheehy @Neeharika-Sompalli @Nana-EC @xin-hedera