Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated codeowners for SDK CPP #694

Merged
merged 4 commits into from
May 10, 2024
Merged

Conversation

rbarkerSL
Copy link
Contributor

Description:
Misaligned Code ownership in original gha/ci update

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
@rbarkerSL rbarkerSL self-assigned this May 9, 2024
@rbarkerSL rbarkerSL requested review from a team as code owners May 9, 2024 17:04
@rbarkerSL rbarkerSL changed the title Updated codeowners for SDK CPP fix: Updated codeowners for SDK CPP May 9, 2024
@rbarkerSL rbarkerSL requested a review from nathanklick May 9, 2024 17:04
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to add @hashgraph/limechain-hedera as a codeowner. See #687

Signed-off-by: Roger Barker <roger.barker@swirldslabs.com>
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbarkerSL rbarkerSL requested review from rwalworth and removed request for tomzhenghedera May 9, 2024 21:23
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbarkerSL rbarkerSL merged commit 76e0c12 into main May 10, 2024
2 checks passed
@rbarkerSL rbarkerSL deleted the fix-codeowners-for-sdk-cpp branch May 10, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants