Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Long from SDK #2107

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Export Long from SDK #2107

merged 2 commits into from
Feb 1, 2024

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Jan 31, 2024

Description:

Export Long from SDK in order to be used when it works with larger numbers.

Fixes #2106

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: svetoslav-nikol0v <svetoslav.nikolov@limechain.tech>
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb01e23) 76.24% compared to head (dc636e9) 84.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2107      +/-   ##
===========================================
+ Coverage    76.24%   84.35%   +8.10%     
===========================================
  Files          305      305              
  Lines        76104    76114      +10     
===========================================
+ Hits         58027    64205    +6178     
+ Misses       18077    11909    -6168     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v svetoslav-nikol0v merged commit db1f3b5 into develop Feb 1, 2024
9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2106-export-long-from-sdk branch February 1, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Long from SDK
2 participants